Bugfix Codicon Circles #1261
Merged
Bugfix Codicon Circles #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here examples of the various tries: Current situation
This looks reasonable for The
ScaleGroupsVertA new scaling group type added, seems to look good:
And here a proportional font
Here it also seems to look good, albeit the quasi-cellsize is a bit wide. Legacy situationMeans
|
Codicons: Maximise all circles [why] The scaling works okay for `Nerd Font Mono` fonts, but not for `Nerd Font` fonts. The later have 'unexpected' left side bearing, which looks even more out of place because the width is unrelated to the advance width and might place the majority of the glyph into the next cell. [how] In fact we do not want scaling and shifting to be uniform for all glyphs but the intend was to get the scaling from the biggest (full size) circle and all the smaller ones would be proportionally smaller. So we add a new Scale grouping that just takes the scale and the vertical shift of the combined boundingbox, but individually calculates the horizontal shift. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this pull request
May 30, 2023
See PR #1261 for details on the reasons. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
bugfix/codicons-circles
branch
from
05da381
to
41d5b06
Compare
Finii
force-pushed
the
bugfix/codicons-circles
branch
from
41d5b06
to
ba1d16b
Compare
Finii
force-pushed
the
bugfix/codicons-circles
branch
from
ba1d16b
to
c8dd880
Compare
This reverts commit fcf5c84. [why] There is no current usecase for the ScaleGroupVert.
3 tasks
Closed
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
See PR ryanoasis#1261 for details on the reasons. This mostly reverts commit f84a4a4 font-patcher: Add Codicons scale list Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
Bugfix Codicon Circles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert scaling of (most of) the Codicons back to individual maximize as it has been with
v2.3and before.On the way a new Scaling method is introduced and removed again as it does technically solve the problem but probably people do not want relative consistency but big icons i.e. maximizing.
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Fixes: #1240
Screenshots (if appropriate or helpful)