Add Intel One Mono #1275

sorashi · 2023-06-01T11:19:02Z

Description

Added and patched Intel One Mono

Requirements / Checklist

Read the Contributing Guidelines
Verified the license of any newly added font, glyph, or glyph set

What does this Pull Request (PR) do?

add Intel One Mono unpatched font
add license & readme
rename the resulting font due to OTF license reserved font name requirement
- had to edit font-patcher
- I chose the name Intone Mono, but I'm open to suggestions
patch the font
update readme
provide an update script for the font

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Closes #1238

Screenshots (if appropriate or helpful)

Finii · 2023-06-02T05:15:01Z

Thanks for the PR!

The patched fonts are generated by the workflow and should not be included in the PR (but you do not need to remove them now).
I just looked superficially, but it seems the RFN clause is missing in the FontnameTools. --makegroups 0 is of course not what we want for release fonts. But also no worrys.

My 'problem' with this font (and similar PRs) is mostly that it consists of a very large number of styles and weights. I am not sure the more exotic ones are of any particular interest. That would not matter if they are not in the repo, which is growing exponentially.

We need to somehow change the release mechanism, as detailed elsewhere. There are some constrains and problems that are not solved yet. One way could be to put the patched fonts in the release artifact but NOT in the repo. That means people need to download the release zip (or even better the xz) of a desired font and can not select just one font file. Do you think that is an acceptable course? Already existing fonts will of course stay in the repo, also patched, at least for the time being.

And generally, at the moment I mostly try to fix the last 1 or 2 remaining issues of v3.0.1 to get v3.0.2 out. Only if we got a stable v3.0 out I will have time to add fonts or stuff for a v3.1.

Finii · 2023-06-02T05:17:26Z

I chose the name Intone Mono, but I'm open to suggestions

I like that name :-D

sorashi · 2023-06-02T07:08:24Z

it consists of a very large number of styles and weights

True, it would make sense to include just Regular, Bold, Italic and maybe Bold-Italic

That means people need to download the release zip (or even better the xz) of a desired font and can not select just one font file. Do you think that is an acceptable course?

Absolutely, that seems very reasonable to me. Build artifacts should not be tracked in the repo of course, I just thought you did it like this, because other fonts are tracked. Now I see that they are committed by CI, if I understand correctly.

And generally, at the moment I mostly try to fix the last 1 or 2 remaining issues of v3.0.1 to get v3.0.2 out. Only if we got a stable v3.0 out I will have time to add fonts or stuff for a v3.1.

Sure, I will try to keep an eye out and later rebase and update this PR if needed. Or just ping me. :)

Other than that, is there anything I should do at the moment, concerning this PR?

Finii · 2023-06-02T08:27:07Z

Everything find, no need to do anything.

Now I see that they are committed by CI

Yes. In principle I would like to change (i.e. drop) that, but some repackagers fetch the fonts for historic reasons from there. We had some discussions on that. For sure we can drop that for newly added fonts ;-D

And in principle the whole setup should change, separating the patcher from the prepatched fonts, and we already have the organization set up ... but that is very slow going.

I hope to release 3.0.2 this weekend, then we could discuss release modus of operandi ;-) if you are interested. One problem is that I can discuss all the thing just we me, which makes no lively discussions :-D

Finii · 2023-06-02T08:32:01Z

and later rebase

There is no need to rebase (and if, I will do it right before merging). As this mainly just adds new files there will be no conflicts and the few text lines that need to be added can be done manually. There are also changes in the gh-pages that need to be performed in sync anyhow, I believe. The font-example needs to be installed there. Or did I automatize that already? 🤔 Does not matter.

Edit:

Obviously not...

yooakim · 2023-06-08T05:47:38Z

Thanks for putting in work here @sorashi and @Finii - I look forward to be able to use the Intel One Mono with glyphs and more :-)

pkking · 2023-07-26T03:50:22Z

Any progress on this PR?

Finii · 2023-07-26T05:21:02Z

Thanks @pkking; in principle this is very easy to do, and iirc the v3.1.0 is due already.

But I still have a problem with the release model. What we did in the past just does not scale - the in-repo patched fonts are a burden for everyone.

One possible solution is this:

Put the unpatched fonts in the repo (as before)
Create the release with the release archives per font (i.e. IntoneMono.zip and IntoneMono.tar.zx) on the release page
in patched/fonts/IntelMono/ we have no individual fonts but just a page that directs people to download the release archive (with link)
That means no possibility to download individual patched fonts from the Github repo pages

Any opinions (from anyone) on this are welcome!

[why] Patching process is unknown. Patching has to be done by the CI. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

No functional change Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] We do not (try to) copy the upstream webpage, but instead link it. Also add version information (well, there is no difference between 1.2.0 and 1.2.1, but 1.2.1 is the latest right now). Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] -makegroups 0 is not a valid naming mode for releases. The mode is deprecated and will be removed. Furthermore the mode can produce broken patched fonts. [how] Mode 1 and 2 are too long for some NFP in the family name, so use mode 4. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-07-26T06:32:13Z

We need to adapt...

[why] Verbs have been dropped from Inkscape with version 1.2 [how] Use actions instead. I'm not sure how well that works with older Inkscapes now, but ... sigh [note] Also add missing helper for font filenames for Intel One Mono. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-07-26T07:16:08Z

Rebase on master - force push.

Change some minor details. Most notably is the naming change; it will get the abbreviated NF instead of the more lengthy Nerd Font added to the name to comply with name length limits.

* The programmingfonts.org link was wrong * The description has to be in abbreviated style Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] We have a lot duplicated code here. [how] As the to and to-dir never changes we can assign that outside all the if cases. We can also always just add the extra information to the (only one, independent of number of incoming data files) output after all the ifs. Note that this also adds the extra information if we had no readme at all. Previous code would not add anything to that (for whatever reason). Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] Some fonts will not be released to the repo; but only exist patched as release atrifacts. This needs adapted readmes. [how] If such a font is encountered direct links to the release archives are put into the readme file. Decide based on information in the font.json file. If no info is found in the json file (i.e. all existing fonts) it defaults to release-also-to-repo behavior. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-07-26T13:02:12Z

I guess we can pull this now and out-of-sync release the font to see and check if this is a good way for future releases.

Will manually simulate the release process.

Finii · 2023-07-26T14:07:16Z

Looks like it works...

Finii · 2023-07-26T14:10:28Z

@allcontributors please add @sorashi for code

allcontributors · 2023-07-26T14:10:37Z

@Finii

I've put up a pull request to add @sorashi! 🎉

Finii · 2023-07-26T14:12:42Z

Note to self: The download button could be split in halves, one zip and one xz 🤔

Finii · 2023-07-26T14:54:09Z

Whoever is interested, Cask is in the pipeline: Homebrew/homebrew-cask-fonts#7971

All other packagers probably are triggered only by a new Nerd Fonts release.
I 'smuggled' the font in with the old 3.0.2 release 😬 We have no good workflow for new fonts 🤔

pkking · 2023-07-29T01:40:41Z

@Finii Thank you!

Finii added the ❲Aa❳ new font label Jun 2, 2023

sorashi and others added 6 commits July 26, 2023 08:06

Add Intel One Mono

5a8d017

IntelOne: Remove prepatched fonts

3d9d838

[why] Patching process is unknown. Patching has to be done by the CI. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

name-parser: Sort SIL table

fe108ad

No functional change Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

name-parser: Add IntelOne replacement to SIL table

3da2bbf

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

IntelOne: Unify README

0e01e02

[why] We do not (try to) copy the upstream webpage, but instead link it. Also add version information (well, there is no difference between 1.2.0 and 1.2.1, but 1.2.1 is the latest right now). Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii force-pushed the intel-one-mono branch from 20ad614 to 16342a2 Compare July 26, 2023 07:13

Finii added this to the v3.1.0 milestone Jul 26, 2023

Finii added 4 commits July 26, 2023 14:44

IntelOne: Correct minor settings glitches

3cf3c7c

* The programmingfonts.org link was wrong * The description has to be in abbreviated style Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

IntelOne: Prevent in-repo-release

91138ea

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii force-pushed the intel-one-mono branch from 16342a2 to 91138ea Compare July 26, 2023 12:46

Finii merged commit 548cd4e into ryanoasis:master Jul 26, 2023
5 checks passed

allcontributors bot mentioned this pull request Jul 26, 2023

docs: add sorashi as a contributor for code #1323

Merged

dtrodr mentioned this pull request Aug 11, 2023

Please add glyphs (icons) support - Nerd Fonts Patch intel/intel-one-mono#37

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Intel One Mono #1275

Add Intel One Mono #1275

sorashi commented Jun 1, 2023 •

edited

Loading

Finii commented Jun 2, 2023

Finii commented Jun 2, 2023

sorashi commented Jun 2, 2023

Finii commented Jun 2, 2023

Finii commented Jun 2, 2023 •

edited

Loading

yooakim commented Jun 8, 2023

pkking commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

allcontributors bot commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

pkking commented Jul 29, 2023

Add Intel One Mono #1275

Add Intel One Mono #1275

Conversation

sorashi commented Jun 1, 2023 • edited Loading

Description

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented Jun 2, 2023

Finii commented Jun 2, 2023

sorashi commented Jun 2, 2023

Finii commented Jun 2, 2023

Finii commented Jun 2, 2023 • edited Loading

yooakim commented Jun 8, 2023

pkking commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

allcontributors bot commented Jul 26, 2023

Finii commented Jul 26, 2023

Finii commented Jul 26, 2023

pkking commented Jul 29, 2023

sorashi commented Jun 1, 2023 •

edited

Loading

Finii commented Jun 2, 2023 •

edited

Loading