Allow not renaming the font with parameter #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The font_patcher object should be self contained, and code outside of it should not depend on stuff done within it that does not have to do anything with patching. In fact the code should run even if font_patcher.patch() has not been called. [how] Pull name backup out of the patching process. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] For tweaking we use the self.sourceFont, but in the loop the real correct value is the local sourceFont. Usually it's the same, but from a logical standpoint this is wrong. The name is a bit unfortunate and C++ would have generated a warning. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] When we did not collect xavgwidth data for some font and want to tweak it the font-patcher crashes. [how] Check if we have a number before accessing it in the array. [note] This happens when font_patcher.patch() has not been called. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Sometimes a user might want to keep the original name. This is escpecially true as Visual Studio seems to look at the font names directly and enables special handling for 'Cascadia Code'. Users might want to self-patch without renaming. [how] Add additional value to makegroups option. That option should probably be renamed into 'naming scheme' or something, as it is not really a fitting description of what it does. Fixes: #1242 (some aspect of it) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
12 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a flag for the user to not-rename (not touch) the name fields.
This can be useful for Visual Strudio and Cascadia Code, see #1242 (comment)
Requirements / Checklist
What does this Pull Request (PR) do?
See description.
Also corrects some logic errors (that do not really have an effect, but are nonetheless wrong).
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)
Are in the issue.