Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsolata go #130

Merged
merged 2 commits into from
Apr 22, 2017
Merged

Inconsolata go #130

merged 2 commits into from
Apr 22, 2017

Conversation

sodiumjoe
Copy link
Contributor

@sodiumjoe sodiumjoe commented Feb 12, 2017

Description

Added the font InconsolataGo (an experimental, tentatively titled version of Inconsolata with straight quotes by the original author).

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Adds new font InconsolataGo.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@ryanoasis
Copy link
Owner

@sodiumjoe Hey thanks for contribution 😄 . I cannot promise when I will do the merge but you can be sure it will happen 😉

@ryanoasis ryanoasis modified the milestone: v1.1.0 Feb 19, 2017
@ryanoasis
Copy link
Owner

Ping. haven't forgotten about this. will definitely go in next release

@ryanoasis
Copy link
Owner

@sodiumjoe Sorry that I haven't gotten to this yet. I thank you for your patience and your contribution.

We are finally making some progress toward getting a dev branch up with all the latest fixes, etc. Also I think we are going to improve the process (and therefore time) to merge in PRs

@ryanoasis ryanoasis merged commit bbd3d55 into ryanoasis:master Apr 22, 2017
@sodiumjoe
Copy link
Contributor Author

what's the release schedule? wondering when I'll be able to brew install this.

@ryanoasis
Copy link
Owner

@sodiumjoe I was thinking about doing releases once a month:

  • whatever is merged into master at that time would go in the release
  • items that don't make it wouldn't hold up the entire release
  • items that don't make it would get their chance in the next release

I am open to any suggestions or thoughts you may have on this or ways to improve

@sodiumjoe
Copy link
Contributor Author

that seems fine to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants