Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for metrics and boxdrawing #1300

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Add option for metrics and boxdrawing #1300

merged 4 commits into from
Oct 13, 2023

Commits on Oct 13, 2023

  1. font-patcher: Add option to select metrics source 

    [why]
If the font has contradicting baseline to baseline metrics the patcher
tries to find a sane value and use that. That automatism gets it right
in most cases, but there might be fonts where the user wants a different
metric to be used.

At the moment the use would need to use `font-line` to adjust the
metrics, which is not very convenient.

[how]
Add option to select one of the metricses.
Use that metrics when setting up the patched font.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    @Finii
    Finii committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    72fb7fb View commit details
    Browse the repository at this point in the history

  2. font-patcher: Add option to force patching in box drawing glyphs 

    [why]
When the original font designer's idea of cell height differs from the
height we deduce the box drawing glyphs come out with the wrong size (if
we do not touch them, for example because the font already has a
complete set).

[how]
Add option that enforces patch-in of the box set.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    @Finii
    Finii committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    c7b7cc9 View commit details
    Browse the repository at this point in the history

  3. font-patcher: Sort and regroup help message 

    [why]
It can be hard to find the 'usual' options in between all the expert
options.

[how]
Regroup the options and sort them alphabetically (most of the time).
Not sure if this helps, but in my personal view this makes it easier.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    @Finii
    Finii committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    9bfe6d1 View commit details
    Browse the repository at this point in the history

  4. font-patcher: Drop some option alternatives 

    [why]
It is rather confusing to have so many aliases.

[how]
Remove some long forms and some alternatives, to make the help page
easier to read.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    @Finii
    Finii committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    99f3b20 View commit details
    Browse the repository at this point in the history