Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font: Envy Code R #1318

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Add font: Envy Code R #1318

merged 1 commit into from
Jul 15, 2023

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Jul 15, 2023

Requirements / Checklist

RFN clause, renaming still tbd

What does this Pull Request (PR) do?

Add new font Envy Code R

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

#1205

Screenshots (if appropriate or helpful)

@Finii
Copy link
Collaborator Author

Finii commented Jul 15, 2023

Sorry this took so long, and we still have no new-release-scheme (which is what kept me from adding new fonts).

Anyhow, there is one question to @damieng:
The license has an RFN clause. That means that we can not name the patched font "EnvyCodeR Nerd Font" (which would be the 'normal' patched name) - except you give us an exception to the license (like for example Mononoki).

Maybe you have a good patched font name, usually with RFN we try to come up with a somehow similar name.
Or you allow reusing the name parts just here for the Nerd Font patching.

Either is ok of course. And also if you prefer to not suggest anything we will come up with a 'new' name.

Thank you again for the font, the responses, the patience :-)

Edit: For example we could / will use EnviedCoder

@Finii Finii added this to the v3.1.0 milestone Jul 15, 2023
@damieng
Copy link

damieng commented Jul 15, 2023

I give my permission for it to be called "Envy Code R Nerd Font"

The font has RFN, but we are allowed to use the patched name
"Envy Code R Nerd Font", see PR #1318.

Thanks go to Damien Guard!

Fixes: #1205

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator Author

Finii commented Jul 15, 2023

Thank you very much :-)

@Finii Finii marked this pull request as ready for review July 15, 2023 13:17
@Finii Finii merged commit 9512cdd into master Jul 15, 2023
@Finii Finii deleted the feature/add-envycoder branch July 15, 2023 13:17
@Finii
Copy link
Collaborator Author

Finii commented Jul 15, 2023

I sneaked it in as 'Release v3.0.2'; noticed that we have no real way to add fonts, as half the commits are automated but they would have to wait till the next release etc... For the other pending font additions I have to think about a solution.

Anyhow, Envy Code R now fully published:

image

@Finii
Copy link
Collaborator Author

Finii commented Jul 15, 2023

Note to self:

Additional commits needed, full commit list:

9512cdd Add font: Envy Code R
57f17e2 Add font: Envy Code R (fix)
ad8ee0c Add Envy Code R patched

And for the pages:

763c03c [ci] Sync fonts.json
3f232db Add Envy Code R preview

@Finii
Copy link
Collaborator Author

Finii commented Jul 16, 2023

Publish on Homebrew finished: Homebrew/homebrew-cask-fonts#7915

I do not contribute to other packagers.

@Finii Finii changed the title Draft: Add font: Envy Code R Add font: Envy Code R Jul 16, 2023
@Finii Finii mentioned this pull request Sep 27, 2023
3 tasks
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
The font has RFN, but we are allowed to use the patched name
"Envy Code R Nerd Font", see PR ryanoasis#1318.

Thanks go to Damien Guard!

Fixes: ryanoasis#1205

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants