install.sh: Honor XDG_DATA_HOME #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] When a user sets the XDG_DATA_HOME environment variable the default of $HOME/.local/share should not be used. https://wiki.archlinux.org/title/XDG_Base_Directory [how] Enable XDG_DATA_HOME to override the default user data directory on Unix and MacOS platforms. There is some controversy if XDG_DATA_HOME should be honored on MacOS, see for example platformdirs (link below). But me also working on Linux and MacOS (and Windows) in parallel, I can not quite follow the downsides and believe we should allow XDG_DATA_HOME also for MacOS. Related: tox-dev/platformdirs#4 Fixes: #1324 Suggested-by: Anthony Foglia <@afoglia> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
When a user sets the
XDG_DATA_HOMEenvironment variable the default of$HOME/.local/shareshould not be used.https://wiki.archlinux.org/title/XDG_Base_Directory
[how]
Enable
XDG_DATA_HOMEto override the default user data directory on Unix and MacOS platforms.There is some controversy if
XDG_DATA_HOMEshould be honored on MacOS, see for example platformdirs (link below). But me also working on Linux and MacOS (and Windows) in parallel, I can not quite follow the downsides and believe we should allowXDG_DATA_HOMEalso for MacOS.Related: tox-dev/platformdirs#4
Fixes: #1324
Suggested-by: Anthony Foglia <@afoglia>
Requirements / Checklist
What does this Pull Request (PR) do?
If envvar
XDG_DATA_HOMEis set and the user want to install into a user directory the default path is adjusted accordingly.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)