-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font: 0xProto #1381
Add font: 0xProto #1381
Conversation
@all-contributors please add @piraces for code |
I've put up a pull request to add @piraces! 🎉 |
Hi there! First time contributing to Nerd Fonts. Please let me know if I have something wrong 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks almost good! :-)
Adding a new font is of course always also kind of 'political'.
Is the font interesting enough?
Is there demand?
Etc.
That is of course hard for newly created fonts.
Forgot to write first of all: Thank you for the PR :-) |
Hi @Finii, first of all thank you for all the explication! I think I understood the process now. I have made the suggested changes in overwriting the same commit and "force pushing" (let me know if you are not ok with "force pushes"). Off-topic (kind of): thinking about the contributing.md, adding a new font guide section, I was thinking it may be useful to change it with this "new" steps (I can try to work on that too). Should we track this proposal in a new issue or discussion? Thanks! 👍 |
I wrote something on adding fonts here:
Force pushes are absolutely ok in PRs (and better than having 10 commits that fix fixes ;)
Ah, that is rather old and I completely forgot that section. I still have no solutions for the problems, and the What I wanted to say: I would rather not promote add-a-font PRs. Edit: Fix typos |
Co-authored-by: Fini <ulf.fini.jastrow@desy.de>
I just have made the changes.
I completely understand your point, if I have more time I will work on bugs or something related better than new fonts 😄 |
Can I just comment to support this PR...0xProto is an amazing font to work with. |
I mark this as ready now (i.e. I will update the font just on release, if need be). Ah, I will quickly add a commit that unifies the readme style. |
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Thank you for all @Finii !! 👍 |
0xProto is my favorite code font and I'm glad it's joining nerd font family. |
Description
Add new font 0xProto
Requirements / Checklist
What does this Pull Request (PR) do?
Adds the font 0xProto
How should this be manually tested?
N/A
Any background context you can provide?
I followed the entire contributing guide and tried to base this on other fonts added in successfully merged PRs.
What are the relevant tickets (if any)?
Closes #1379
Screenshots (if appropriate or helpful)
N/A