Add Neovim icon (fixes #1383) #1391

georgeguimaraes · 2023-10-20T18:07:18Z

Description

I decided to take a shot into implementing #1383. Not sure if this is it, or if I should run bin/scripts/gotta-patch-em-all-font-patcher!.sh and commit all the changes. Let me know if this is ok.

Requirements / Checklist

Read the Contributing Guidelines
Verified the license of any newly added font, glyph, or glyph set

What does this Pull Request (PR) do?

Adds the neovim icon as discussed in #1383

How should this be manually tested?

The generated original-source.otf now has the Neovim icon:

Any background context you can provide?

What are the relevant tickets (if any)?

#1383

Screenshots (if appropriate or helpful)

Finii · 2023-10-21T10:39:20Z

Thanks for the PR!

To add a icon one just needs to throw the svg into the correct directory and add a line to icons.tsv. The workflow than automagically updates the i_seti.sh and the original-source.otf (workflow PackSVGs). Maybe we should add that to the comments in icons.tsv?

Manually one needs to

expand the patching range in font-patcher
correct the wiki page

In the original issue you mentioned font-logos. There is a PR pending to add the neovim icon there. You correctly pointed out that the repo seems dead.
But in fact, after #1391 has been raised I investigated and it seems we can revive the repo (see Issue 95 over there).
That would of course be preferred.

So maybe we should wait a bit and see if we can get that going again. The messages seemed rather promising.

Finii · 2023-10-21T10:46:44Z

I believe the font-logos neovim icon has a solid lift-side-bar thing, while here it is hollow (to reflect that it is blue instead of green, a guess).
This is just an observation.

Taken from font-logos fork release

Finii · 2023-10-21T10:59:04Z

The original black-and-white logo published by neovim themselves is like THIS logo, i.e. with a hollow left leg:

https://github.com/neovim/neovim.github.io/blob/master/logos/neovim-logo-1color.svg

georgeguimaraes · 2023-10-22T20:24:26Z

In the original issue you mentioned font-logos. There is a PR pending to add the neovim icon there. You correctly pointed out that the repo seems dead.
But in fact, after #1391 has been raised I investigated and it seems we can revive the repo (see lukas-w/font-logos#95).
That would of course be preferred.

That's interesting! Let's wait then if font-logos comes back to activity. It seems that the maintainer has not given access to other people.

However, I think there may be an underlying question here: Should Nerd Fonts rely on upstream repos that (as you mentioned in that issue) appear to have no standalone use? As oppose to, I'd say, Material Design. Of course, that's just me thinking out loud, it's a questions for nerd fonts' maintainers to discuss. :)

Just hoping to get Neovim icon soon :)

georgeguimaraes · 2023-10-22T20:24:54Z

The original black-and-white logo published by neovim themselves is like THIS logo, i.e. with a hollow left leg:

https://github.com/neovim/neovim.github.io/blob/master/logos/neovim-logo-1color.svg

Yes, that's the one I used (hollow left leg).

georgeguimaraes · 2023-10-22T20:31:42Z

To add a icon one just needs to throw the svg into the correct directory and add a line to icons.tsv. The workflow than automagically updates the i_seti.sh and the original-source.otf (workflow PackSVGs). Maybe we should add that to the comments in icons.tsv?

I guess this paragraph in the contributing file, in a entry regarding new icons, should be enough.

georgeguimaraes · 2023-10-22T20:32:42Z

btw @Finii, tks for the interactions here! I really appreciate the care you have with nerd fonts and all the work

georgeguimaraes · 2023-10-22T20:41:36Z

Manually one needs to

expand the patching range in font-patcher

You mean this line

nerd-fonts/font-patcher

Line 1054 in 18ff974

    
           {'Enabled': True,                           'Name': "Seti-UI + Custom",        'Filename': "original-source.otf",                            'Exact': False, 'SymStart': 0xE4FA, 'SymEnd': 0xE5FF, 'SrcStart': 0xE5FA, 'ScaleRules': None,             'Attributes': SYM_ATTR_DEFAULT},

?

It seems that U+E5AE is already included in that range. Is that so?

Finii · 2023-10-22T21:53:33Z

It seems that U+E5AE is already included in that range. Is that so?

Oh, I anticipated that already in 869d6f9, so there is nothing to do in font-patcher :-)

[why] To avoid filename clashes between Seti and Custom we have all Custom files with a _nf suffix. This has not been documented. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] After a new icon has been added to the core set we want to make that visible via a new version number. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] We want the workflow to do this so that we have control over the fontforge version that is used. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] If the svg file is renamed the icon list has to be updated :rolleyes: Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-10-23T11:55:18Z

Thanks again for the PR.

I hope the changes of the documentation is readable and helps a bit.

Here you can see the workflow in action that crates the new original font:
https://github.com/ryanoasis/nerd-fonts/actions/runs/6612722696/job/17959104734

And here the automatic commits added after your PR:

So the changes are now in the zip and the docker patcher.
All the prepatched fonts will only follow on the next release - to have it already now you need to self patch (or tell me which font(s) you need, I can prepare them)

georgeguimaraes · 2023-10-23T12:46:33Z

Nice changes to contributing.md. Much clearer to understand that all the heavy lifting of patching the fonts and committing them to the repo is done by the workflows.

I'll try to patch Victor Mono by myself. If I don't succeed I'll ask for help. Thanks so much!

Finii · 2023-10-23T13:32:08Z

@allcontributors please add @georgeguimaraes for code

allcontributors · 2023-10-23T13:32:18Z

@Finii

I've put up a pull request to add @georgeguimaraes! 🎉

Finii · 2023-10-23T13:33:35Z

Nearly forgot...

I always struggle with the type; code seems not fitting, but all other are also not really good. I believe we used code before for this kind of contribution.

berlinx2104 · 2023-10-27T14:03:17Z

Can you guys reconsider that the left part should be overpainted so it's actually easier to see at the terminal? That edge is really small to see at the terminal. Anyway, thank you so much for taking the time to make it and I respect all your decisions.

Finii · 2023-10-27T14:27:24Z

@berlinx2104 Thanks for the feedback!

I will try to improve the visibility.

The completely filled symbol is already in Font Logos (see links above) which I expect will pull the PR that contains it soon and afterwards we update that here, so both variants will end up in the patched fonts.
(But unfortunately Lukas did not make one of us Maintainer, yet)

georgeguimaraes · 2023-10-27T16:55:04Z

I kinda got used to see it as a modified "V", but yes, the left leg is too subtle. Maybe it was a design decision by the Neovim team?

Finii · 2023-10-27T17:06:00Z

Do you think this is better, or not enough?

Finii · 2023-10-27T17:10:13Z

Corrected the aspect ratio:

Finii · 2023-10-27T17:12:53Z

Maybe it was a design decision by the Neovim team?

Well, it was designed to be displayed at a much bigger size. That is why icons come in different sizes, because rescaling usually is not good enough. Here I increased the gap and increased the 'stroke width' of the left leg. In that process I changed the angle of the middle-bar. If I do not change that the ascpect ratio changes, see image above.

georgeguimaraes · 2023-10-27T17:15:50Z

That looks way better (the 2nd version)

Finii · 2023-10-27T17:19:31Z

Ok, I will push that, so that you (both) can try it out in real...

Finii · 2023-10-27T17:35:16Z

Changes pushed via 27f6ea1

ZIP and docker ready.

georgeguimaraes · 2023-10-27T18:51:18Z

It is certainly more visible. I can clearly see the hollow leg on my terminal now. Thanks, @Finii

berlinx2104 · 2023-10-28T17:36:35Z

Thanks, @Finii

ryanoasis/nerd-fonts#1391

…icon-to-custom Add Neovim icon (fixes ryanoasis#1383)

Add Neovim icon and run generate-original-source.py

bc374ce

georgeguimaraes force-pushed the gg-add-neovim-icon-to-custom branch from 11b96df to bc374ce Compare October 20, 2023 18:09

georgeguimaraes changed the title ~~Add Neovim icon (solves #1383)~~ Add Neovim icon (fixes #1383) Oct 20, 2023

Finii added 6 commits October 23, 2023 13:15

neovim: Improve filename

43eb9a1

[why] To avoid filename clashes between Seti and Custom we have all Custom files with a _nf suffix. This has not been documented. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

doc: Improve contributing manual

7bceb83

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

doc: Further contributing information on icon core set

654855a

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

font-patcher: Increase after new core icon

5615d5e

[why] After a new icon has been added to the core set we want to make that visible via a new version number. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Revert: "run generate-original-source.py"

3d860fb

[why] We want the workflow to do this so that we have control over the fontforge version that is used. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Fixup: neovim: Improve filename

5a7ab77

[why] If the svg file is renamed the icon list has to be updated :rolleyes: Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii merged commit 39dd0cb into ryanoasis:master Oct 23, 2023
0 of 5 checks passed

allcontributors bot mentioned this pull request Oct 23, 2023

docs: add georgeguimaraes as a contributor for code #1394

Merged

Finii added this to the v3.1.0 milestone Oct 23, 2023

konradmalik mentioned this pull request Oct 23, 2023

Neovim icon in status bar konradmalik/neovim-flake#1

Closed

mikesmithgh mentioned this pull request Oct 25, 2023

feat: Add Neovim Nerd Font Icon mikesmithgh/kitty-scrollback.nvim#38

Closed

georgeguimaraes deleted the gg-add-neovim-icon-to-custom branch October 27, 2023 17:14

perrin4869 added a commit to perrin4869/dotfiles that referenced this pull request Nov 21, 2023

chore(neovim): use new neovim nerdfonts icon

c863ef8

ryanoasis/nerd-fonts#1391

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023

Merge pull request ryanoasis#1391 from georgeguimaraes/gg-add-neovim-…

3693d9e

…icon-to-custom Add Neovim icon (fixes ryanoasis#1383)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Neovim icon (fixes #1383) #1391

Add Neovim icon (fixes #1383) #1391

georgeguimaraes commented Oct 20, 2023 •

edited

Loading

Finii commented Oct 21, 2023

Finii commented Oct 21, 2023

Finii commented Oct 21, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

Finii commented Oct 22, 2023

Finii commented Oct 23, 2023

georgeguimaraes commented Oct 23, 2023

Finii commented Oct 23, 2023

allcontributors bot commented Oct 23, 2023

Finii commented Oct 23, 2023

berlinx2104 commented Oct 27, 2023

Finii commented Oct 27, 2023

georgeguimaraes commented Oct 27, 2023

Finii commented Oct 27, 2023

Finii commented Oct 27, 2023

Finii commented Oct 27, 2023

georgeguimaraes commented Oct 27, 2023

Finii commented Oct 27, 2023

Finii commented Oct 27, 2023

georgeguimaraes commented Oct 27, 2023

berlinx2104 commented Oct 28, 2023

Add Neovim icon (fixes #1383) #1391

Add Neovim icon (fixes #1383) #1391

Conversation

georgeguimaraes commented Oct 20, 2023 • edited Loading

Description

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented Oct 21, 2023

Finii commented Oct 21, 2023

Finii commented Oct 21, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

georgeguimaraes commented Oct 22, 2023

Finii commented Oct 22, 2023

Finii commented Oct 23, 2023

georgeguimaraes commented Oct 23, 2023

Finii commented Oct 23, 2023

allcontributors bot commented Oct 23, 2023

Finii commented Oct 23, 2023

berlinx2104 commented Oct 27, 2023

Finii commented Oct 27, 2023

georgeguimaraes commented Oct 27, 2023

Finii commented Oct 27, 2023

Finii commented Oct 27, 2023

Finii commented Oct 27, 2023

georgeguimaraes commented Oct 27, 2023

Finii commented Oct 27, 2023

Finii commented Oct 27, 2023

georgeguimaraes commented Oct 27, 2023

berlinx2104 commented Oct 28, 2023

georgeguimaraes commented Oct 20, 2023 •

edited

Loading