-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Geist Mono #1398
feat: add Geist Mono #1398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Technically this looks good 👍
But this fails to explain why the font should be added.
There seems to be no Issue or Discussion.
Also maybe missing is an explanation what makes this font great ;-)
There are a lot fonts that multiple persons are interested in, and there is kind of a limit how many fonts we can handle.
Thanks for the quick review! I addressed all your comments.
Apologize for this - this font is very new (released yesterday), made specifically for developers and designers (as per their README). I patched the font locally to use it in my development environment and thought that other folks might show interest in using it with Nerd Fonts. I totally understand if you don't accept fonts that are brand new / not widely used yet though! |
I'd love to see this font as an avid user of nerdfonts.com 😁 |
Was going to make a PR for Geist as well. I'm a huge fan of nerd fonts and a total Vercel simp. Would love the convenient way to get the font setup on all machines. I'd also like to add that its a bit easier to get a feel for the font and understand the reasoning behind it via the https://vercel.com/font |
I also would love this. |
I just started using Geist Mono in my IDE, would love to be able to use it in my terminal as well! +1-ing this. |
@QuiiBz Thanks for keeping this up to date 👍 I really need to create at least a list of fonts to include in |
Nice that it was merged, but I cannot find the font. |
I guess you have to wait until v3.1.0 is really released 😆 Albeit I would have loved to trigger the release this weekend, we still have to wait for the decision on RFN of Monaspace. |
Lmao, that is ok. But what is it with companies releasing fonts lately 🤣 |
@allcontributors pleas add @QuiiBz for code |
I've put up a pull request to add @QuiiBz! 🎉 |
Thank you :) |
Description
Add the Geist Mono font.
Requirements / Checklist
What does this Pull Request (PR) do?
Add the Geist Mono font.
How should this be manually tested?
N/A
Any background context you can provide?
Not sure if I followed all the steps correctly, I was stuck at the fourth step but it seems like it's not required.
What are the relevant tickets (if any)?
N/A
Screenshots (if appropriate or helpful)
N/A