Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Geist Mono #1398

Merged
merged 3 commits into from
Nov 11, 2023
Merged

feat: add Geist Mono #1398

merged 3 commits into from
Nov 11, 2023

Conversation

QuiiBz
Copy link
Contributor

@QuiiBz QuiiBz commented Oct 28, 2023

Description

Add the Geist Mono font.

Requirements / Checklist

What does this Pull Request (PR) do?

Add the Geist Mono font.

How should this be manually tested?

N/A

Any background context you can provide?

Not sure if I followed all the steps correctly, I was stuck at the fourth step but it seems like it's not required.

What are the relevant tickets (if any)?

N/A

Screenshots (if appropriate or helpful)

N/A

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Technically this looks good 👍

But this fails to explain why the font should be added.
There seems to be no Issue or Discussion.
Also maybe missing is an explanation what makes this font great ;-)

There are a lot fonts that multiple persons are interested in, and there is kind of a limit how many fonts we can handle.

bin/scripts/lib/fonts.json Outdated Show resolved Hide resolved
bin/scripts/lib/fonts.json Outdated Show resolved Hide resolved
bin/scripts/lib/fonts.json Outdated Show resolved Hide resolved
@Finii
Copy link
Collaborator

Finii commented Oct 28, 2023

Lets see what is special with Geist ;-)

image

  • Easy to distinguish one and small-ell (1 vs l)
  • Impossible to distinguish zero and capital-Oh (0 vs O)
  • It has a tilde-minus ligature (?! Which language uses that?)

image

image

I was just curious.

@QuiiBz
Copy link
Contributor Author

QuiiBz commented Oct 28, 2023

Thanks for the quick review! I addressed all your comments.

But this fails to explain why the font should be added.
There seems to be no Issue or Discussion.
Also maybe missing is an explanation what makes this font great ;-)

Apologize for this - this font is very new (released yesterday), made specifically for developers and designers (as per their README). I patched the font locally to use it in my development environment and thought that other folks might show interest in using it with Nerd Fonts.

I totally understand if you don't accept fonts that are brand new / not widely used yet though!

@rauchg
Copy link

rauchg commented Oct 30, 2023

I'd love to see this font as an avid user of nerdfonts.com 😁

@metruzanca
Copy link

metruzanca commented Oct 31, 2023

Was going to make a PR for Geist as well. I'm a huge fan of nerd fonts and a total Vercel simp. Would love the convenient way to get the font setup on all machines.

I'd also like to add that its a bit easier to get a feel for the font and understand the reasoning behind it via the https://vercel.com/font

@Finii Finii added this to the v3.1.0 milestone Nov 1, 2023
@Finii Finii added the Ready ⛱ Ready to merge but waiting to be merged near a release label Nov 1, 2023
@FormalSnake
Copy link

I also would love this.

@BoxingOctopus
Copy link

I just started using Geist Mono in my IDE, would love to be able to use it in my terminal as well! +1-ing this.

@Finii
Copy link
Collaborator

Finii commented Nov 8, 2023

@QuiiBz Thanks for keeping this up to date 👍

I really need to create at least a list of fonts to include in v3.1, but there is so much to do.
And then there is the inclusion of simple-icons that I would really like for that revision. So many decisions...
I guess the Cascadia Code problems will not be solved with 3.1, not enough time...

@Finii Finii merged commit 65d82d6 into ryanoasis:master Nov 11, 2023
1 check passed
@FormalSnake
Copy link

Nice that it was merged, but I cannot find the font.

@Finii
Copy link
Collaborator

Finii commented Nov 11, 2023

Nice that it was merged, but I cannot find the font.

I guess you have to wait until v3.1.0 is really released 😆

Albeit I would have loved to trigger the release this weekend, we still have to wait for the decision on RFN of Monaspace.
Hopefully that will be Monday/Tuesday or something.

@FormalSnake
Copy link

Lmao, that is ok. But what is it with companies releasing fonts lately 🤣

@Finii
Copy link
Collaborator

Finii commented Nov 11, 2023

@allcontributors pleas add @QuiiBz for code

Copy link
Contributor

@Finii

I've put up a pull request to add @QuiiBz! 🎉

@ruantiengo
Copy link

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready ⛱ Ready to merge but waiting to be merged near a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants