Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Font Logos to 1.1.1 #1427

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

hasecilu
Copy link
Contributor

@hasecilu hasecilu commented Nov 21, 2023

Description

  • Update font-logos.ttf file to version 1.1.1
  • Update upper limit range on font-patcher script
  • Update i_logos.sh lib file

Requirements / Checklist

What does this Pull Request (PR) do?

Update Font Logos to 1.1.1

How should this be manually tested?

Check md5sum (ecc30c6fd3d35c8e9e2789b3d01ff36a) is the same to the one on release 1.1.1 and include it to SymbolsNerdFont.

Any background context you can provide?

After a little pause the font-logos project has been updated

What are the relevant tickets (if any)?

#1424

Screenshots (if appropriate or helpful)

The new logos goes from f330 to f372
image
Banner
header

[why]
The font-logos project has been updated including 67 new icons, in which
are included GNU/Linux distributions, desktop environments, window
managers, desktop applications, some organizations and more.

Now the used range is F300-F372, 115 available logos.
@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Waaah @hasecilu 💚

Thank you so much!

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

What is this? 😒

image

WHAT?

image

Anyhow, not my (ancient Nerd Font) font 😌

How did you update the i_*.sh is there a script (just curiousity).

We also need to update the Wiki. https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points

@Finii Finii merged commit 4c82de8 into ryanoasis:master Nov 21, 2023
5 of 6 checks passed
@Finii Finii added this to the v3.1.0 milestone Nov 21, 2023
@hasecilu
Copy link
Contributor Author

How did you update the i_*.sh is there a script (just curiousity).

I used:

from=F330
to=F372
from=$(printf '%d' "0x$from") to=$(printf '%d' "0x$to")
while test "$from" -le "$to"; do
        num=$(printf '%04x' "$from")
        echo -en "i='\u$num' i_linux_=\$i\n"
        from=$((from + 1))
done

Then I tried to do a visual copy with the names on icons.tsv file with Neovim but since the \n chars were copied I had to manually type the names -__-

We also need to update the Wiki. https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points

Well, I don't have permissions in the wiki, so I leave that for your todo list.

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Thank you.

Ah, I thought everyone can edit.
Unfortunately I have no rights to grant any rights. I have barely enough rights to keep this live 😬

And then ... when your workflows break apart for no obvious reasons...
I guess today the whole day will be release work :-/

image

The workflow, when it runs through, takes some hours (3..4?)

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Ah, release workflow now running

https://github.com/ryanoasis/nerd-fonts/actions/runs/6940642493

Hoping for a smooth ride...

image

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Wiki updated.

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Something changed.... It's almost ready and only one hour?

And always NOTO, how I do hate NOTO

image

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

OH NO!!!!

Just noticed that I called Monaspace Radon -> Monaspice Rd which should have been Rn 😒

I guess I will correct that manually afterwards. There is always something.

@hasecilu
Copy link
Contributor Author

Cool!, new version is out.

Is the Diagram created using @SankeyMATIC automagically updated or manually? Now there are 115 logos 😎

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

There are instructions in the readme

https://github.com/ryanoasis/nerd-fonts/tree/master/bin/scripts/data/sankey

But with such a small change I would rather just edit the svg and sneak in the 'wrong' (=new) number :-D

This is not hard in inkscape and I did it before for 3.0.2 iirc.

Also the Seti+Custom number of icons increased by ... 3 or so.

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Addendum:

I would not recommend creating a completely new diagram, because there are several manual steps involved, change font size, put the icon visual left and right etc pp. That really takes time. Editing the svg is ... ready in 5 Minutes.

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

This is the source of all images: https://github.com/ryanoasis/nerd-fonts/blob/master/bin/scripts/data/sankey/sankey-glyphs-3.0.0.svgz, change that, export as png and optimized svg, save the new version also here as full-inkspace-compressed svg with version in the filename.

@Finii
Copy link
Collaborator

Finii commented Nov 21, 2023

Sankey diagram updated.

@hasecilu
Copy link
Contributor Author

Thanks!, I was about to start on that, just a minor detail: the white background doesn't "fills" the whole text string, it's a little short
image

@hasecilu hasecilu deleted the update_font_logos branch November 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants