Bugfix/visualstudio2022 #1442

Finii · 2023-11-27T14:01:27Z

Description

If --makegroups is >= 4 the name suffix Nerd Font (Nerd Font Mono, Nerd Font Propo) is shortened to NF (NFM, NFP). But not everywhere. To show the nice long name in applications that can handle long names, the long name is always (!) written to ID16.

VisualStudio 2022 does not like that and assumes the font is broken.
For that reason this extra rule (write the long name to ID16 even though all other places use the abbreviation) has been removed with v3.1.0. But that breaks all configurations that address the font by family name, because the long name is gone now.

This PR implements a work around such that two (!) family names are written to ID16, the short and the long one.
In this way both VisualStudio 2022 and configured family name applications can be happy.

Hopefully.

Requirements / Checklist

Read the Contributing Guidelines
Verified the license of any newly added font, glyph, or glyph set

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Fixes: #1482

Screenshots (if appropriate or helpful)

[why] This sets out to circumvent a problem with VisualStudio 2022. That application seems to have problems with fonts when the ID16 is not a prefix in ID1. We have this when --makegroups >= 4, because ID1 has the short name suffix 'NF' ID16 has the long suffix 'Nerd Font' These fonts can be selected in VisualStudio 2022, and the preview works ok, but one active some replacement default font is used instead. See more discussions in #1442 [how] Write both forms in ID16 fields, 'NF' and 'Nerd Font' suffixes. This works as long as the application considers all languages equal. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] This sets out to circumvent a problem with VisualStudio 2022. That application seems to have problems with fonts when the ID16 is not a prefix in ID1. We have this when --makegroups >= 4, because ID1 has the short name suffix 'NF' ID16 has the long suffix 'Nerd Font' These fonts can be selected in VisualStudio 2022, and the preview works ok, but once active some replacement default font is used instead. The problem vanishes if ID16 and ID1 have the same stem, or rather ID1 has someting added on top of ID16; but ID16 is a substring of ID1. See more discussions in #1442 [how] Write both forms in ID16 fields, 'NF' and 'Nerd Font' suffixes. This works as long as the application considers all languages equal. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-11-27T14:25:42Z

History, watch out for ID16 (compare to ID1):

v3.0.2 (broken)

======== CaskaydiaCoveNerdFont-LightItalic.ttf ========
SFNT Fullname      ID 4     CaskaydiaCove NF Light Italic
SFNT Family        ID 1     CaskaydiaCove NF Light
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    CaskaydiaCove Nerd Font
SFNT Pref Styles   ID 17    Light Italic
SFNT PS Name       ID 6     CaskaydiaCoveNF-LightItalic
SFNT Compatible    ID 18    
SFNT CID findfont  ID 20    
SFNT WWS Family    ID 21    
SFNT WWS SubFamily ID 22    
PS fontname                 CaskaydiaCoveNF-LightItalic
PS fullname                 CaskaydiaCove NF Light Italic
PS familyname               CaskaydiaCove NF Light
fondname                    None

v3.1.0 (ok)

======== CaskaydiaCoveNerdFont-LightItalic.ttf ========
SFNT Fullname      ID 4     CaskaydiaCove NF Light Italic
SFNT Family        ID 1     CaskaydiaCove NF Light
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    CaskaydiaCove NF
SFNT Pref Styles   ID 17    Light Italic
SFNT PS Name       ID 6     CaskaydiaCoveNF-LightItalic
SFNT Compatible    ID 18    
SFNT CID findfont  ID 20    
SFNT WWS Family    ID 21    
SFNT WWS SubFamily ID 22    
PS fontname                 CaskaydiaCoveNF-LightItalic
PS fullname                 CaskaydiaCove NF Light Italic
PS familyname               CaskaydiaCove NF Light
fondname                    None

v3.1.1 (broken)

This reverts v3.1.0, i.e. is in fact v3.0.2 again

======== CaskaydiaCoveNerdFont-LightItalic.ttf ========
SFNT Fullname      ID 4     CaskaydiaCove NF Light Italic
SFNT Family        ID 1     CaskaydiaCove NF Light
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    CaskaydiaCove Nerd Font
SFNT Pref Styles   ID 17    Light Italic
SFNT PS Name       ID 6     CaskaydiaCoveNF-LightItalic
SFNT Compatible    ID 18    
SFNT CID findfont  ID 20    
SFNT WWS Family    ID 21    
SFNT WWS SubFamily ID 22    
PS fontname                 CaskaydiaCoveNF-LightItalic
PS fullname                 CaskaydiaCove NF Light Italic
PS familyname               CaskaydiaCove NF Light
fondname                    None

v3.1.1-6 (ok)

======== CaskaydiaCoveNerdFont-LightItalic.ttf ========
SFNT Fullname      ID 4     CaskaydiaCove NF Light Italic
SFNT Family        ID 1     CaskaydiaCove NF Light
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    ('CaskaydiaCove Nerd Font', 'CaskaydiaCove NF')
SFNT Pref Styles   ID 17    ('Light Italic', 'Light Italic')
SFNT PS Name       ID 6     CaskaydiaCoveNF-LightItalic
SFNT Compatible    ID 18    
SFNT CID findfont  ID 20    
SFNT WWS Family    ID 21    
SFNT WWS SubFamily ID 22    
PS fontname                 CaskaydiaCoveNF-LightItalic
PS fullname                 CaskaydiaCove NF Light Italic
PS familyname               CaskaydiaCove NF Light
fondname                    None

[why] This sets out to circumvent a problem with VisualStudio 2022. That application seems to have problems with fonts when the ID16 is not a prefix in ID1. We have this when --makegroups >= 4, because ID1 has the short name suffix 'NF' ID16 has the long suffix 'Nerd Font' These fonts can be selected in VisualStudio 2022, and the preview works ok, but once active some replacement default font is used instead. The problem vanishes if ID16 and ID1 have the same stem, or rather ID1 has someting added on top of ID16; but ID16 is a substring of ID1. See more discussions in #1442 [how] Write both forms in ID16 fields, 'NF' and 'Nerd Font' suffixes. This works as long as the application considers all languages equal. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-11-27T19:01:45Z

To set up a test set, with the PR applied:

$ NERDFONTS="--makegroups 4" ./gotta-patch-em-all-font-patcher\!.sh -j /CascadiaCode

Just the Nerd Font variants to try:
Caskaydia_3.1.1-6.tar.xz.zip (1.7M)

Finii · 2023-11-27T20:52:51Z

This talk from Thomas Phinney / Adobe has some details:
https://localfonts.eu/wp-content/uploads/2017/11/Font-names.pdf

If there is no relation between 1 and 16 VisualStudio 2022 breaks, that seems to be odd and not according to expectations. And it was not the case for VisualStudio 2019. I really believe this is a Microsoft .... glitch.

And the usual suspects for documentation
https://learn.microsoft.com/en-us/typography/opentype/spec/name#name-ids
https://learn.microsoft.com/en-us/typography/opentype/spec/recom#name-strings

[why] This sets out to circumvent a problem with VisualStudio 2022. That application seems to have problems with fonts when the ID16 is not a prefix in ID1. We have this when --makegroups >= 4, because ID1 has the short name suffix 'NF' ID16 has the long suffix 'Nerd Font' These fonts can be selected in VisualStudio 2022, and the preview works ok, but once active some replacement default font is used instead. The problem vanishes if ID16 and ID1 have the same stem, or rather ID1 has someting added on top of ID16; but ID16 is a substring of ID1. See more discussions in #1442 [how] Write both forms in ID16 fields, 'NF' and 'Nerd Font' suffixes. This works as long as the application considers all languages equal. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2024-01-15T17:50:27Z

Rebase on master to retrigger codeclimate 😬

Finii · 2024-01-15T18:07:14Z

Ah yes, now I remember (the hurt)

[why] This sets out to circumvent a problem with VisualStudio 2022. That application seems to have problems with fonts when the ID16 is not a prefix in ID1. We have this when --makegroups >= 4, because ID1 has the short name suffix 'NF' ID16 has the long suffix 'Nerd Font' These fonts can be selected in VisualStudio 2022, and the preview works ok, but once active some replacement default font is used instead. The problem vanishes if ID16 and ID1 have the same stem, or rather ID1 has someting added on top of ID16; but ID16 is a substring of ID1. See more discussions in #1442 [how] Write both forms in ID16 fields, 'NF' and 'Nerd Font' suffixes. This works as long as the application considers all languages equal. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2024-03-17T14:36:19Z

Rebase on master, force push

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] Albeight documented in the comment not all non English-US entries are removed but just al TO_DEL ones. [how] Put the conditional in the right position. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] This sets out to circumvent a problem with VisualStudio 2022. That application seems to have problems with fonts when the ID16 is not a prefix in ID1. We have this when --makegroups >= 4, because ID1 has the short name suffix 'NF' ID16 has the long suffix 'Nerd Font' These fonts can be selected in VisualStudio 2022, and the preview works ok, but once active some replacement default font is used instead. The problem vanishes if ID16 and ID1 have the same stem, or rather ID1 has someting added on top of ID16; but ID16 is a substring of ID1. See more discussions in #1442 [how] Write both forms in ID16 fields, 'NF' and 'Nerd Font' suffixes. This works as long as the application considers all languages equal. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] The code is rather convoluted and one can not follow what is done. [how] Add function that abstracts some steps away. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] This sets out to circumvent a problem with VisualStudio 2022. That application seems to have problems with fonts when the ID16 is not a prefix in ID1. We have this when --makegroups >= 4, because ID1 has the short name suffix 'NF' ID16 has the long suffix 'Nerd Font' These fonts can be selected in VisualStudio 2022, and the preview works ok, but once active some replacement default font is used instead. The problem vanishes if ID16 and ID1 have the same stem, or rather ID1 has someting added on top of ID16; but ID16 is a substring of ID1. See more discussions in #1442 [how] Write both forms in ID16 fields, 'NF' and 'Nerd Font' suffixes. This works as long as the application considers all languages equal. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii force-pushed the bugfix/visualstudio2022 branch from 0c86382 to 936e664 Compare November 27, 2023 14:02

Finii force-pushed the bugfix/visualstudio2022 branch from 936e664 to 24d971d Compare November 27, 2023 14:15

Finii force-pushed the bugfix/visualstudio2022 branch from 24d971d to 5cffe3f Compare November 27, 2023 17:32

This was referenced Nov 27, 2023

(Caskaydia Code and) Visual Studio 2022 #1242

Closed

Font can not be found after update to 3.1.0 (name for config changed) #1434

Closed

Finii force-pushed the bugfix/visualstudio2022 branch from 5cffe3f to ae3d873 Compare December 4, 2023 09:43

Finii mentioned this pull request Jan 1, 2024

Bugfix/revert name change #1439

Merged

2 tasks

Finii mentioned this pull request Jan 12, 2024

Nerdfonts CaskaydiaMono-3.1.1 and CaskaydiaCove-3.1.1 do not work in Notepad++ notepad-plus-plus/notepad-plus-plus#14578

Closed

Finii force-pushed the bugfix/visualstudio2022 branch from ae3d873 to 3dab9ee Compare January 15, 2024 17:49

Finii force-pushed the bugfix/visualstudio2022 branch from 319d3d0 to c32d23a Compare March 17, 2024 14:35

Finii added 2 commits March 17, 2024 19:08

query_name: Examine all languages

62d1f67

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

name_parser: Do remove non-US SFNT entries

07d17ab

[why] Albeight documented in the comment not all non English-US entries are removed but just al TO_DEL ones. [how] Put the conditional in the right position. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii force-pushed the bugfix/visualstudio2022 branch from c32d23a to f463c2c Compare March 17, 2024 18:09

Finii force-pushed the bugfix/visualstudio2022 branch from f463c2c to 46afeb4 Compare March 17, 2024 18:10

name-parser: Simplify code

5295697

[why] The code is rather convoluted and one can not follow what is done. [how] Add function that abstracts some steps away. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii force-pushed the bugfix/visualstudio2022 branch from 46afeb4 to 5295697 Compare March 17, 2024 19:25

Finii marked this pull request as ready for review March 17, 2024 19:27

Finii merged commit f9e1116 into master Mar 17, 2024
5 checks passed

Finii deleted the bugfix/visualstudio2022 branch March 17, 2024 19:36

Finii mentioned this pull request Jul 8, 2024

Font naming inconsistences #1673

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/visualstudio2022 #1442

Bugfix/visualstudio2022 #1442

Finii commented Nov 27, 2023 •

edited

Loading

Finii commented Nov 27, 2023 •

edited

Loading

Finii commented Nov 27, 2023

Finii commented Nov 27, 2023 •

edited

Loading

Finii commented Jan 15, 2024

Finii commented Jan 15, 2024

Finii commented Mar 17, 2024

Bugfix/visualstudio2022 #1442

Bugfix/visualstudio2022 #1442

Conversation

Finii commented Nov 27, 2023 • edited Loading

Description

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented Nov 27, 2023 • edited Loading

v3.0.2 (broken)

v3.1.0 (ok)

v3.1.1 (broken)

v3.1.1-6 (ok)

Finii commented Nov 27, 2023

Finii commented Nov 27, 2023 • edited Loading

Finii commented Jan 15, 2024

Finii commented Jan 15, 2024

Finii commented Mar 17, 2024

Finii commented Nov 27, 2023 •

edited

Loading

Finii commented Nov 27, 2023 •

edited

Loading

Finii commented Nov 27, 2023 •

edited

Loading