Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Latest configuration for devcontainer.json and Dockerfile #1476

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

mdsanima
Copy link
Contributor

@mdsanima mdsanima commented Jan 9, 2024

Description

Please explain the changes you made here.

Requirements / Checklist

What does this Pull Request (PR) do?

Updating the .devcontainer configuration to latest version.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The devcontainer has been introduced silently with

and no explanation given why we possibly want that.

Maybe you can explain what the advantages are or the use-cases, maybe adding documentation. To be honest I was on the brink of removing it some months ago for uselessness and non-documentation.

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@mdsanima
Copy link
Contributor Author

As for documentation, I can write it, can you tell me where? Should this be in the READMD.md file or maybe in some other file?

@Finii
Copy link
Collaborator

Finii commented Jan 10, 2024

As for documentation, I can write it, can you tell me where? Should this be in the READMD.md file or maybe in some other file?

That would be great! Just a ./devcontainer/README.md maybe is enough?

@Finii
Copy link
Collaborator

Finii commented Jan 10, 2024

@allcontributors please add @mdsanima for code

Copy link
Contributor

@Finii

I've put up a pull request to add @mdsanima! 🎉

@mdsanima
Copy link
Contributor Author

I just added the documentation. I think this is enough instruction for this. If necessary, I can also translate this documentation into Polish. @Finii can you review this? Thanks!

@Finii
Copy link
Collaborator

Finii commented Jan 10, 2024

Personally I believe translations age not gracefully, i.e. get out of sync more or less quickly.

Thanks for adding the explanation/readme!

I will pull this in the next minutes.

Just out of interest... Why would one want to use THIS instead of just the docker container that we always keep up to date [1] directly 🤔

I mean, if you have docker installed, you just need to

docker run --rm -v /path/to/fonts:/in:Z -v /path/for/output:/out:Z nerdfonts/patcher [OPTIONS]

which will download the most up to date font-patcher etc etc.
Maybe this is a leftover from the time where we did not automagically rebuild the container on every push?

[1] https://hub.docker.com/r/nerdfonts/patcher

image

@Finii Finii merged commit c4f613a into ryanoasis:master Jan 10, 2024
1 check passed
@mdsanima mdsanima deleted the fix/devcontainer-config branch January 10, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants