-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Latest configuration for devcontainer.json
and Dockerfile
#1476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The devcontainer has been introduced silently with
and no explanation given why we possibly want that.
Maybe you can explain what the advantages are or the use-cases, maybe adding documentation. To be honest I was on the brink of removing it some months ago for uselessness and non-documentation.
As for documentation, I can write it, can you tell me where? Should this be in the READMD.md file or maybe in some other file? |
That would be great! Just a |
@allcontributors please add @mdsanima for code |
I've put up a pull request to add @mdsanima! 🎉 |
I just added the documentation. I think this is enough instruction for this. If necessary, I can also translate this documentation into Polish. @Finii can you review this? Thanks! |
79752b5
to
c017547
Compare
Personally I believe translations age not gracefully, i.e. get out of sync more or less quickly. Thanks for adding the explanation/readme! I will pull this in the next minutes. Just out of interest... Why would one want to use THIS instead of just the docker container that we always keep up to date [1] directly 🤔 I mean, if you have docker installed, you just need to
which will download the most up to date font-patcher etc etc. |
Description
Please explain the changes you made here.
Requirements / Checklist
What does this Pull Request (PR) do?
Updating the
.devcontainer
configuration to latest version.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)