Update Noto fonts #1478
Merged
Update Noto fonts #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the different ligature removal calls are becoming more and more a problem, because we have only one config.json for all fonts in a font-root-directory. But the Noto variants have the ligatures in different lookups. With the new font we finally remove lookups in the new font that have a completely different contents then the lookups we wanted to remove in the other family. So the config.json is becoming more flexible: Now first we seach in the concrete font file directory and only if there is no config we progress to the font root directory and search there. See also commit d9f7dbe Prepatched fonts: Revive some ligature removal Here we have * fi and similar in lookup 41 * l-dot and similar in lookups 13, 14, 15 Fixes: #1472 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
We keep all ligatures with the Serif font, i.e. `ldot` and `fi` et al. This font is very proportional anyhow. As there are no ligs active in the old Noto Mono font and the other have their own configs we can just remove the root config. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Noto fonts
Requirements / Checklist
What does this Pull Request (PR) do?
Update the Noto fonts.
Changes the ligature removal for Noto Serif (stops the removal).
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
En passant:
Fixes: #1472
Screenshots (if appropriate or helpful)