Bugfix/devicons #1548
Merged
Bugfix/devicons #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The font file is not changed, it is still the 9 year old file. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The glyph is extremely complex with very thin open spaces and bridges. Obviously a conversion from some colored icon that has not been looked at too hard. [how] Remove all the small crevices, smoothen the surface carefully and make too thin strokes a bit wider. We still keep the Devicons goal "very crisp icons" so that no rounding of the paths and reduction of points is used. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
to Finii/devicons
that referenced
this pull request
Mar 18, 2024
[why] The glyph is extremely complex with very thin open spaces and bridges. Obviously a conversion from some colored icon, without QC afterwards. [how] Remove all the small crevices, smoothen the surface carefully and make too thin strokes a bit wider. We still keep the Devicons goal "very crisp icons" so that no rounding of the paths and reduction of points is used. Related: ryanoasis/nerd-fonts#1548 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
The glyph is extremely complex with very thin open spaces and bridges.
Obviously a conversion from some colored icon that has not been looked
at too hard.
[how]
Remove all the small crevices, smoothen the surface carefully and make
too thin strokes a bit wider.
We still keep the Devicons goal "very crisp icons" so that no rounding
of the paths and reduction of points is used.
Requirements / Checklist
What does this Pull Request (PR) do?
Fix the surfaces...:
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)
Before and after: