FontAwesome: Update to 6.5.1 #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finii
force-pushed
the
feature/update-fontawesome
branch
from
f718fa5
to
b9d12cb
Compare
Finii
force-pushed
the
feature/update-fontawesome
branch
from
b9d12cb
to
4e318d3
Compare
We specifically use the SVGs to create the intermediate carrier (font file) that is used later to patch fonts, to get the icons with a more relaxed license. That should be noted in the audit. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/update-fontawesome
branch
from
4e318d3
to
3eab0c8
Compare
hasecilu
pushed a commit
to hasecilu/nerd-fonts
that referenced
this pull request
Apr 3, 2024
This does not pull in all icons of 6.5.1, but only of 'Region A' and 'Region B', see script `remix` and PR ryanoasis#1563. It keeps the codepoints constant for existing icons. Fixes: ryanoasis#1550 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Hi, I detected that the glyph I don't know if similar problems are found in other glyphs so I can't tell the severity of the "bug".
|
|
Moved comment to #1596 |
|
We can the also incorporate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the codepoints they assign to the icons (and they do have codepoint stability it seems), we can divide the Font Awesome icons into three (artifical) regions:
F000-F2FF(Region A)F300-F8FF(Region B)E000-EFFF(Region C)Region A is their dedicated allocation within Nerd Fonts codepoint space. At
F300the next set (Font Logos) starts.For backward compatibility codepoints of existing icons in Region A have to be kept. The other codepoints (i.e. icons in Region B and C) fall to other icons sets' codepoint in Nerd Fonts space and have to be moved.
The question is how and where.
Possible scenario:
We could patch Region A to the codepoints of the current FA, filling the gaps with some of Region B.
The rest of Region B fits into
ED00-EFFFThis PR does not introduce the icons from Region C.
This PR does not introduce
RegularandSolid(except where both variants were already inFont Awesome 4.3).For licensing reasons we use the svgs and not the release font files. We loose their placement within the glyph bounding box this way, but I guess the scheme of placement we use now is not worse. For that soem actual patched fonts need to be inspected, esp the
Nerd Font Propovariants.Fixes: #1550
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)