Fix Powerline glyphs position and size in some cases #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finii
force-pushed
the
bugfix/Powerline-in-square-fonts
branch
2 times, most recently
from
a539be0
to
1210d88
Compare
|
Comparing Nerd Font MonoNO CHANGE
Nerd Font (which is secretly Propo)
Examples (left is 4.14.7, right 4.14.8)
Not exactly what I wanted I guess. |
[why] The right align check does produce wrong results if a proportional font is generated. [how] Just skip the aspect ratio alignment re-check and leave the work to the proportional font shifting that is done afterwards anyhow. Fixes: #1695 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
bugfix/Powerline-in-square-fonts
branch
from
1210d88
to
3c2a10a
Compare
|
Now only the right aligned icons are different, and the original / proportional width is kept.
Left: pre PR, right after PR, changed glyphs marged with blue tag I'm much more comfortable with this change,which is minimal. Making the Powerline glyphs monospaced, albeight I believe that is what they ought to be, that might break other people's setup, and noone ever complained. |
|
Checked with SymbolsOnly and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct right aligned glyphs in proportional fonts (i.e.
--variable).Only very few icons are right aligned, all Powerline glyphs.
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)