Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the font family name for mono fonts #178

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

lilyball
Copy link
Collaborator

@lilyball lilyball commented Jul 11, 2017

Description

Add " Mono" to the font family name when generating single-wide fonts.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

How should this be manually tested?

Run ./font-patcher with the -s flag and check the generated fonts.

What are the relevant tickets (if any)?

Fixes #176.

@lilyball
Copy link
Collaborator Author

Assuming there are pre-patched mono fonts, they'll need to be regenerated.

@ryanoasis
Copy link
Owner

@kballard Thanks I'll take a look at and test it this weekend.

Assuming there are pre-patched mono fonts, they'll need to be regenerated.

Yep, so I will probably tie this to release 1.1 (because rebuilding all the fonts takes a good chunk of time), but at the very least perhaps we can get the logic fix merged into the code

@ryanoasis ryanoasis added this to the v1.1.0 milestone Jul 24, 2017
@ryanoasis ryanoasis merged commit 0b59fad into ryanoasis:master Jul 24, 2017
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Change the font family name for mono fonts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants