Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting #381

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Fix formatting #381

merged 1 commit into from
Oct 12, 2019

Conversation

this-is-you
Copy link
Contributor

Description

Please explain the changes you made here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@ryanoasis
Copy link
Owner

Nice fixes, thank you. Looks much better

There is a small problem, the way we build these compiled readmes if from the src folder, in this case it was a txt file and gets compiled into a markdown and that's when the formatting seems to get messed up.

In this case the original coming from https://github.com/ryanoasis/nerd-fonts/tree/master/src/unpatched-fonts/BigBlueTerminal

I think this is a good fix for now, pending possibly a better way to handle combining these patched readmes by the script: https://github.com/ryanoasis/nerd-fonts/blob/master/bin/scripts/standardize-and-complete-readmes.sh

@ryanoasis ryanoasis added this to the v2.1.0 milestone Oct 12, 2019
@ryanoasis ryanoasis merged commit 3616d6b into ryanoasis:master Oct 12, 2019
@ryanoasis ryanoasis mentioned this pull request Oct 12, 2019
5 tasks
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Fixes formatting (possibly a temporary solution)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants