Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation for README #389

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

delphinus
Copy link
Collaborator

@delphinus delphinus commented Oct 21, 2019

Description

This adds Japanese version of README.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

@delphinus delphinus marked this pull request as ready for review October 22, 2019 08:15
@delphinus
Copy link
Collaborator Author

Completed. Review this, please.

@ryanoasis ryanoasis added this to the v2.1.0 milestone Oct 24, 2019
@ryanoasis
Copy link
Owner

ryanoasis commented Oct 24, 2019

Very nice, thank you for the continued contributions! 🏅

It looks good to me (visual scan and spot checked some text)

Edit: I updated #118 with your contribution - checked it off the list

@ryanoasis ryanoasis merged commit 7216e59 into ryanoasis:master Oct 24, 2019
@delphinus delphinus deleted the feature/japanese-readme branch October 24, 2019 01:19
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants