Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider .ttc in docker entrypoint #664

Merged
merged 2 commits into from
Nov 27, 2021
Merged

Conversation

kraftwerk28
Copy link
Contributor

@kraftwerk28 kraftwerk28 commented Sep 13, 2021

Description

Adds one more glob to docker-entrypoint.sh

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

How should this be manually tested?

By running docker run ... (https://github.com/ryanoasis/nerd-fonts#option-8-patch-your-own-font)

Any background context you can provide?

Iosevka font has .ttc file extension to the script won't work

@kraftwerk28
Copy link
Contributor Author

I wonder if it's reasonable to just write for f in /in/* ..., since there are a lot of font file extensions

@ryanoasis
Copy link
Owner

I wonder if it's reasonable to just write for f in /in/* ..., since there are a lot of font file extensions

That's a good point. I say this fix is a good improvement and later we can make it less selective if it gets too unwieldy

@ryanoasis
Copy link
Owner

I think this is fine, just note that ttc not supported: #175

@ryanoasis ryanoasis merged commit ecb07a9 into ryanoasis:master Nov 27, 2021
@Finii Finii mentioned this pull request Jan 5, 2022
2 tasks
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Consider .ttc in docker entrypoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants