font-patcher: Check if glyph source is available (--glyphdownload)
#741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if we want to go that route, but it is requested a lot it seems...: Autodownload...
|
|
Two notes:
If we go the route with the second commit there might be problems of |
Finii
changed the title
--glyphdownload)
This was referenced Jan 27, 2022
Closed
Finii
added a commit
that referenced
this pull request
Feb 6, 2022
[why] People might want to use the font-patcher with just the one script file. The error message does not help them to understand the problem. [how] Require the modules only if the user wants to use it (i.e. --makegroups). Give the expected path in the error message. We could also download the missing files instead, similar to #741 But that PR did not get any feedback yet, so I do not know if this is something we want. Anyhow, the fetching of missing parts should then be unified for both usecases (i.e. Fontname* and src/glyphs). And then, there is font-patcher.zip (which needs to be adapted), maybe that is the way to go. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this pull request
May 13, 2022
[why] People might want to use the font-patcher with just the one script file. The error message does not help them to understand the problem. [how] Require the modules only if the user wants to use it (i.e. --makegroups). Give the expected path in the error message. We could also download the missing files instead, similar to #741 But that PR did not get any feedback yet, so I do not know if this is something we want. Anyhow, the fetching of missing parts should then be unified for both usecases (i.e. Fontname* and src/glyphs). And then, there is font-patcher.zip (which needs to be adapted), maybe that is the way to go. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this pull request
Aug 20, 2022
[why] People might want to use the font-patcher with just the one script file. The error message does not help them to understand the problem. [how] Require the modules only if the user wants to use it (i.e. --makegroups). Give the expected path in the error message. We could also download the missing files instead, similar to #741 But that PR did not get any feedback yet, so I do not know if this is something we want. Anyhow, the fetching of missing parts should then be unified for both usecases (i.e. Fontname* and src/glyphs). And then, there is font-patcher.zip (which needs to be adapted), maybe that is the way to go. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this pull request
Aug 22, 2022
[why] People might want to use the font-patcher with just the one script file. The error message does not help them to understand the problem. [how] Require the modules only if the user wants to use it (i.e. --makegroups). Give the expected path in the error message. We could also download the missing files instead, similar to #741 But that PR did not get any feedback yet, so I do not know if this is something we want. Anyhow, the fetching of missing parts should then be unified for both usecases (i.e. Fontname* and src/glyphs). And then, there is font-patcher.zip (which needs to be adapted), maybe that is the way to go. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this pull request
Sep 7, 2022
[why] When users just download the script (and not the source glyphs) the script fails with an obscure error message. [how] Check if the glyphdir exists at all. If not give a hint to download the glyphs. Check if the individual glyph font exists and is readable. Bail out if not. [note] Cherry picked, was part of #741 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/check-glyph-file-existing
branch
from
d09e346
to
3dad8c1
Compare
|
Rebase on master, force push. One of the original commits is already in master. |
|
All readme files need to be corrected 🛑 |
3 tasks
|
Does this download the |
[why] People often just download the font-patcher script and then the patching fails because the symbol glyphs are missing. A typical comment is that a complete git clone is needed in that case, which is rediculous bandwidth. Just downloading the needed files seems rather complicated. [how] Add option --glyphdownload that (tries to) download just the needed glyph files. This is just bare basic stuff. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/check-glyph-file-existing
branch
from
3dad8c1
to
8c16442
Compare
|
I believe we should promote the |
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] People might want to use the font-patcher with just the one script file. The error message does not help them to understand the problem. [how] Require the modules only if the user wants to use it (i.e. --makegroups). Give the expected path in the error message. We could also download the missing files instead, similar to ryanoasis#741 But that PR did not get any feedback yet, so I do not know if this is something we want. Anyhow, the fetching of missing parts should then be unified for both usecases (i.e. Fontname* and src/glyphs). And then, there is font-patcher.zip (which needs to be adapted), maybe that is the way to go. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] When users just download the script (and not the source glyphs) the script fails with an obscure error message. [how] Check if the glyphdir exists at all. If not give a hint to download the glyphs. Check if the individual glyph font exists and is readable. Bail out if not. [note] Cherry picked, was part of ryanoasis#741 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
When users just download the script (and not the source glyphs) the
script fails with an obscure error message.
[how]
Check if the glyphdir exists at all. If not give a hint to download the
glyphs.
Check if the individual glyph font exists and is readable. Bail out if
not.
Add option
--glyphdownloadthat tries to download missing glyph fonts.Requirements / Checklist
What does this Pull Request (PR) do?
Add checks before we open a symbol font and give hints to the users if we can not.
How should this be manually tested?
src/glyphs/(or use--glyphdir), patch a font again (errors out)The two bottom cases a meaningful message should be printed.
--glyphdownload. (all shall work)Any background context you can provide?
For example #659 #662 #495
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)
Edit: Add
--glyphdownloadas that has been added as 2nd commit to the PR