Bugfix: Automatic symbols only font generation #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the empty That does not make much sense either ;-) Whatever. *: Well, it does not need it anymore with the PR, if no glyph is existing the EM is used |
Finii
force-pushed
the
bugfix/symbols-only-font-generation
branch
from
a16b373
to
affbbf1
Compare
|
I consistently typed Fixed and force push to get rid of that embarrassment. |
[why] The symbol only fonts Symbols-1000-em Nerd Font Complete.ttf and 2048-em in `NerdFontsSymbolsOnly/` are generated from some 'almost' empty source fonts, that are assumable in turn generated from the sfd font descriptions in `src/glyphs/`? The process is not documented and we have issues in the generated font (for example the glyph for capital `E` is defined (and empty) #581 #765). [how] Use the existing font definitions from `src/glyphs/*.sfd` directly as source font. That needs a change in font-patcher because the empty fonts have no glyphs that can be used to orient the scaling upon. In that case scale on the source font definitions EM. Then we need patch-em-all to also patch *.sfd fonts. And finally we need patch-em-all to take a font specific command line switch for font-patcher (compare 9e2bc9a of #723) to instruct it to create a ttf rather than a sfd font file. In the sfd file we additionally set the Panose type. And the UnderlinePosition is adjusted to match the current patched font. [note] Also fix wrong glob pattern in patch-em-all `*.[o,t]tf`. The comma is for sure some leftover from a '{}' shell pattern, that is not used anymore. (This comment is probably outdated, due to rebasing.) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Not sure why they are here, all patched fonts reside now in the `patched-fonts/` folder. So we have two times two different symbols only font sets? Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
bugfix/symbols-only-font-generation
branch
from
affbbf1
to
38f0e87
Compare
|
Rebase on master, resolve conflicts by changing to |
[why] The detection if all fonts of a given directory are to be processed is broken if the font files contain blanks (like 'Symbols-1000-em Nerd Font Complete Mono Windows Compatible.ttf') [how] Need to put name argument in quotes... Also fix counting for sfd files (but we never generate them anyhow) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
The symbol only fonts
Symbols-1000-em Nerd Font Complete.ttfand
2048-eminNerdFontsSymbolsOnly/are generated fromsome 'almost' empty source fonts, that are assumable in turn generated
from the sfd font descriptions in
src/glyphs/?The process is not documented and we have issues in the generated font
(for example the glyph for capital
Eis defined (and empty) #581 #765).[how]
Use the existing font definitions from
src/glyphs/*.sfddirectly assource font. That needs a change in
font-patcherbecause the emptyfonts have no glyphs that can be used to orient the scaling upon. In
that case scale on the source font definitions EM.
Then we need patch-em-all to also patch
*.sfdfonts.And finally we need
patch-em-allto take a font specific command lineswitch for
font-patcher(compare 9e2bc9a of #723) to instruct it tocreate a
ttfrather than asfdfront file.In the sfd file we additionally set the Panose type.
And the UnderlinePosition is adjusted to match the current patched font.
[note]
Also fix wrong glob pattern in patch-em-all
*.[o,t]tf. The comma isfor sure some leftover from a '{}' shell pattern, that is not used
anymore.
Requirements / Checklist
What does this Pull Request (PR) do?
Autogenerate the symbols only fonts from the
sdftemplates and not thettftemplates.How should this be manually tested?
Any background context you can provide?
Automatic generation from
ttffiles: #479Issues with
ttffiles: #581 #765What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)