Bugfix fontconfig #920
Merged
Bugfix fontconfig #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Table is still unsorted. [how] First we ran on '.', which includes all fonts, and then the font directories one by one, but we have traversed them already ... Do not run on '.' :-} Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Some (the most basic) Families are not added. [how] The used shell array search is string based and can/will fail when we search for a short string that is present in a array entry as substring. Use explicit search instead. [note] Also remove some debugging output. Fixes: #918 Reported-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Despite the fact that the workflow generates a new fontconfig, it is never committed back to the repo. [how] As usual people rely on $PWD, which is not set in CI runs. Use the subshell call $(pwd) instead, as that works always. Reported-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Has not been updated in the last release CI run. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a correct fontconfig file
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Install it and see if font substitution works.
Any background context you can provide?
What are the relevant tickets (if any)?
#918
Screenshots (if appropriate or helpful)