Bugfix/hasklug ligature #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Only one tables is removed, even if we want to remove more. With 0a480bb the indentation of the code has changed, and now the loop is (apart from printing) empty. See also #934 [how] Re-indent the lines to restore functionality as originally forseen with commit 557fc00. Reported-by: Rádler Ákos <akos.radler@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Entering two consecutive vertical-bars (i.e. `||`) results in the display of just one - the right - bar glyph. [how] The ligature removal is only partially implemented. The rule at work here is not removed. There are two parts at work: One rule to replace the first bar with nothing. One rule to replace the second bar with a ligarture glyph with negative left bearing, that shows two bars. The second rule has been removed, but the first is still there. This commit also removes the first rule. [note] The whole design here is broken. We remove only some rules and leave others intact, for reasons unknown to me. Other ligartures will also be only partially removed and leave the user with unreadable output. We should either remove all (!) tables and not just some, or leave the ligatures in the font. As the ligature removal has been broken at large anyhow (see previous commit), I would suggest to not remove any ligatures (anymore). Fixes: #934 Reported-by: Rádler Ákos <akos.radler@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix double bar (
||) ligature removal inHasklug Nerd Font Mono.Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Install Mono font. Open
writer, select that font, type bar bar (||). Two bars?Any background context you can provide?
#934
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)