Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsx #210

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Add tsx #210

merged 1 commit into from
Oct 13, 2017

Conversation

dustinblackman
Copy link
Contributor

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

Add an icon for .tsx, copying the one from .jsx.

How should this be manually tested?

Create a .tsx file, load NERDTree, profit.

Any background context you can provide?

There is no .tsx icon set at the moment so it adds the React logo just like .jsx.

Screenshots (if appropriate or helpful)

screen shot 2017-07-28 at 9 30 52 am

@ryanoasis
Copy link
Owner

Create a .tsx file, load NERDTree, profit.

Right on 😉 thanks

@ryanoasis ryanoasis added this to the v0.9.3 milestone Jul 28, 2017
@dustinblackman
Copy link
Contributor Author

@ryanoasis Still plan on merging this?

@ryanoasis
Copy link
Owner

@dustinblackman Yes for sure. Sorry for the delay. I've been busy traveling. I'll be back Monday and next week I'll cobble together a release 😊

@ryanoasis ryanoasis merged commit e60bc98 into ryanoasis:master Oct 13, 2017
@ryanoasis
Copy link
Owner

Thanks for the patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants