Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep all information from denite when adding icon #229

Merged
merged 1 commit into from
Mar 10, 2018

Conversation

carlitux
Copy link
Contributor

@carlitux carlitux commented Feb 19, 2018

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

How should this be manually tested?

Enable denite and list buffers, file_mru, directory_mru, those are new features

What are the relevant tickets (if any)?

#216

@ryanoasis ryanoasis added this to the v0.11.0 milestone Feb 19, 2018
@ryanoasis
Copy link
Owner

ryanoasis commented Feb 19, 2018

@carlitux Awesome, thanks for this! 👍

I see you also added some additional sources

@maxnordlund
Copy link

I noticed all tabs has been converted to spaces, which makes at least me a bit confused as to what has actually changed.

But maybe it's not really important in the end.

@ryanoasis
Copy link
Owner

@maxnordlund Yeah that's a good point/catch.

@carlitux Could you amend your commit and revert the purely indentation changes? That way it is a little easier to diff the changes.

* Solve this issue ryanoasis#216
* Update sources to process
@carlitux
Copy link
Contributor Author

@ryanoasis done.

Just a comment, would be good to add a .editorconfig to use that setup.

@maxnordlund
Copy link

A .editorconfig is a great idea

@ryanoasis
Copy link
Owner

Thanks. Good idea, we should add that.

I think there is not consistency between the files but there should be!

@ryanoasis ryanoasis merged commit d9a8fef into ryanoasis:master Mar 10, 2018
@ryanoasis
Copy link
Owner

Looks good to me ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants