Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leftrelease override to call the activatenode method on single click #246

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

Matrix86
Copy link
Collaborator

@Matrix86 Matrix86 commented Sep 30, 2018

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

When you open a directory on the nerdtree plugin the directory icon doesn't open. This PR permits to call the activatenode method on the single click, when the user try to open a directory.

How should this be manually tested?

Try to open a directory on nerdtree plugin. The icon will change with on the single click event.

Any background context you can provide?

I don't think you need other info.

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

image

@ryanoasis
Copy link
Owner

I realize that with this double click will obviously not be the way to open the directories but I think this might be preferable. Do you have any info on that?

So far this looks good to me...

@ryanoasis ryanoasis merged commit ab417e7 into ryanoasis:master Feb 10, 2019
@der-flo
Copy link

der-flo commented Mar 8, 2019

In my opinion this change collides with let g:NERDTreeMouseMode = 1, which is the default.

https://github.com/scrooloose/nerdtree/blob/master/doc/NERDTree.txt says:

If set to 1 then a double click on a node is required to open it.

Nope, with this commit and let g:DevIconsEnableFoldersOpenClose = 1 single clicks instead of double clicks open dir nodes.

Matrix86 added a commit to Matrix86/vim-devicons that referenced this pull request Mar 8, 2019
@Matrix86
Copy link
Collaborator Author

Matrix86 commented Mar 8, 2019

In my opinion this change collides with let g:NERDTreeMouseMode = 1, which is the default.

https://github.com/scrooloose/nerdtree/blob/master/doc/NERDTree.txt says:

If set to 1 then a double click on a node is required to open it.

Nope, with this commit and let g:DevIconsEnableFoldersOpenClose = 1 single clicks instead of double clicks open dir nodes.

You're right! My bad...I hope the new PR can fix the problem.

@ryanoasis
Copy link
Owner

Thanks. I just felt I wanted to get your work in but I'll review your other PR when able

ryanoasis added a commit that referenced this pull request Jun 23, 2019
#246: fix override when the g:NERDTreeMouseMode = 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants