Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed elixir icons #280

Closed

Conversation

stoicAlchemist
Copy link

@stoicAlchemist stoicAlchemist commented Aug 24, 2019

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

Update Elixir icons

How should this be manually tested?

Open an Elixir project with and without this PR and check the icons

Any background context you can provide?

Using fonts patched, realized the elixir files where not recognized

What are the relevant tickets (if any)?

#279 and #244

Screenshots (if appropriate or helpful)

https://imgur.com/a/uthXXp0

@ryanoasis
Copy link
Owner

Thanks for this but I am wondering why you couldn't see the icon because that is definitely the correct icon for Elixir.

Are you sure your font is up to date?

Nerd Fonts adds the Elixir icon in version 2.0

@stoicAlchemist
Copy link
Author

Yes, I just checked and everything us up to date, I'll dig around to see if this is just a Mac OSX

@stoicAlchemist
Copy link
Author

You were right, apparently I had a corrupt set of fonts, thanks :)

@ryanoasis
Copy link
Owner

Thanks for following up and confirming! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants