Make "style set property" code smaller #440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of low-hanging fruit low effort edit to make the output smaller. It adds a
setStylePropertyhelper.While Solid code is hella small already, the code generated could add up depending on use case. This is a suggestion to make the output smaller.
Given the output, I am figuring there may be more opportunities to make it even smaller. So I'm going to have a look at that. .. 🤔 Yeah, I was able to "optimize" 1 case, from
to
_$pis unused, but treeshaked I suppose.On the performance side of things (besides avoiding that assignement), this adds up a function call, but at the same time, when stuff it's a signal/store it removes a double-access. Without any scientific proof I would guess this performs better... but Im just making that up.