Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#23) fix splash screen #25

Merged
merged 2 commits into from
Apr 24, 2024
Merged

(#23) fix splash screen #25

merged 2 commits into from
Apr 24, 2024

Conversation

ryanw-mobile
Copy link
Owner

We have by mistakes assigned a theme to MainActivity, which made the splash screen to fail on older Android versions.
Together we assigned a smaller icon for the splash screen.
The yaml for renovate Github Action was updated to use JDK 17. Probably we won't have any need to elevate it given we are 100% kotlin.

@ryanw-mobile ryanw-mobile added the fix A bug fix for the user, not a fix to a build script. label Apr 24, 2024
@ryanw-mobile ryanw-mobile requested a review from rwmobi April 24, 2024 20:42
@ryanw-mobile ryanw-mobile self-assigned this Apr 24, 2024
@ryanw-mobile ryanw-mobile linked an issue Apr 24, 2024 that may be closed by this pull request
@ryanw-mobile ryanw-mobile enabled auto-merge April 24, 2024 20:42
@ryanw-mobile ryanw-mobile merged commit 61cabd6 into main Apr 24, 2024
2 checks passed
@ryanw-mobile ryanw-mobile deleted the fix/23-splash-screen branch April 24, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix for the user, not a fix to a build script.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splash screen is not showing up on older Android versions
2 participants