Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#18) media3 player library memory leak #36

Merged
merged 12 commits into from
Apr 29, 2024

Conversation

ryanw-mobile
Copy link
Owner

Replaced the media3 library with our own native implementation, so that we can have direct control on what context to supply to the player - and the memory leak was fixed.

Because we created a new ViewModel, added unit test for it.

Also refactored some UI tests.

@ryanw-mobile ryanw-mobile added the fix A bug fix for the user, not a fix to a build script. label Apr 29, 2024
@ryanw-mobile ryanw-mobile requested a review from rwmobi April 29, 2024 19:51
@ryanw-mobile ryanw-mobile self-assigned this Apr 29, 2024
@ryanw-mobile ryanw-mobile linked an issue Apr 29, 2024 that may be closed by this pull request
@ryanw-mobile ryanw-mobile enabled auto-merge April 29, 2024 19:51
@ryanw-mobile ryanw-mobile merged commit 7ab6cac into main Apr 29, 2024
2 checks passed
@ryanw-mobile ryanw-mobile deleted the fix/18-media3-player-library-memory-leak branch April 29, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix for the user, not a fix to a build script.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media3 Player library memory leak
2 participants