Media 3 Exoplayer fine-tuning

README.md

@@ -9,6 +9,20 @@ The schedule under the Schedule tab refreshes automatically every 30 seconds.
 For both tabs, you can always do swipe-to-refresh, or tap the navigation icon to scroll to the top
 of the list.
 
+## Download the App
+
+If you want to try out the app without building it, check out
+the [Releases section](https://github.com/ryanw-mobile/dazn-code-challenge/releases) where you can
+find the APK and App Bundles for each major release.
+
+### Known issues
+
+The video player has [known _refused-to-fix_ bugs](https://github.com/androidx/media/issues/1270) on
+Android 14 and 15. You may see the video playback not resizing properly. As a workaround, rotating
+the device, toggling between full screen or Picture-in-Picture mode can solve the issue.
+
+ 
+
 ## History
 
 This was a code test assignment as a part of the interview process. The task covered
@@ -34,14 +48,14 @@ any time.
 <p align="center">
   <img src="screenshots/240424_screen0.png" width="150" />
   <img src="screenshots/240424_screen1.png" width="150" />
-  <img src="screenshots/240424_screen2.png" width="150" />
+  <img src="screenshots/240503_screen2.png" width="150" />
   <img src="screenshots/240501_screen4.png" width="150" />
 </p>
 <p align="center">
   <img src="screenshots/240424_screen3.png" width="400" />
 </p>
 
-_&nbsp;
+&nbsp;
 
 ## To-do lists
 
@@ -99,12 +113,6 @@ now [logged as issues](https://github.com/ryanw-mobile/dazn-code-challenge/issue
 * [Github Action](https://github.com/features/actions) - CI/CD
 * [codecov](https://codecov.io/) - code coverage
 
-## Binaries download
-
-If you want to try out the app without building it, check out
-the [Releases section](https://github.com/ryanw-mobile/dazn-code-challenge/releases) where you can
-find the APK and App Bundles for each major version.
-
 ## Requirements
 
 * Android Studio Iguana | 2023.2.1

app/src/main/AndroidManifest.xml

@@ -24,10 +24,11 @@
         tools:targetApi="31">
         <activity
             android:name=".MainActivity"
+            android:configChanges="screenSize|smallestScreenSize|screenLayout|orientation"
             android:exported="true"
+            android:launchMode="singleTask"
             android:resizeableActivity="true"
             android:supportsPictureInPicture="true"
-            android:configChanges="screenSize|smallestScreenSize|screenLayout|orientation"
             android:windowSoftInputMode="adjustResize">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />

app/src/main/java/com/rwmobi/dazncodechallenge/MainActivity.kt

@@ -10,7 +10,6 @@ package com.rwmobi.dazncodechallenge
 import android.content.pm.PackageManager
 import android.content.res.Configuration
 import android.os.Bundle
-import android.util.Rational
 import androidx.activity.ComponentActivity
 import androidx.activity.compose.setContent
 import androidx.activity.enableEdgeToEdge
@@ -29,7 +28,6 @@ import androidx.core.splashscreen.SplashScreen.Companion.installSplashScreen
 import androidx.navigation.compose.rememberNavController
 import com.rwmobi.dazncodechallenge.ui.components.DAZNCodeChallengeApp
 import com.rwmobi.dazncodechallenge.ui.theme.DAZNCodeChallengeTheme
-import com.rwmobi.dazncodechallenge.ui.utils.enterPIPMode
 import com.rwmobi.dazncodechallenge.ui.utils.hasPictureInPicturePermission
 import dagger.hilt.android.AndroidEntryPoint
 import timber.log.Timber
@@ -61,7 +59,6 @@ class MainActivity : ComponentActivity() {
                     isInPictureInPictureMode = isInPipMode,
                     navController = navController,
                     snackbarHostState = snackbarHostState,
-                    onTriggerPIPMode = { enterPIPMode(Rational(16, 9)) },
                 )
             }
         }

app/src/main/java/com/rwmobi/dazncodechallenge/ui/components/DAZNCodeChallengeApp.kt

@@ -46,25 +46,25 @@ import com.rwmobi.dazncodechallenge.ui.theme.dazn_divider
 import com.rwmobi.dazncodechallenge.ui.utils.getPreviewWindowSizeClass
 
 private enum class NavigationLayoutType {
-    BottomNavigation,
-    NavigationRail,
-    FullScreen,
+    BOTTOM_NAVIGATION,
+    NAVIGATION_RAIL,
+    FULL_SCREEN,
 }
 
 private fun WindowSizeClass.calculateNavigationLayout(currentRoute: String?, isInPictureInPictureMode: Boolean): NavigationLayoutType {
     if (currentRoute?.startsWith(AppNavItem.Exoplayer.screenRoute) == true || isInPictureInPictureMode) {
-        return NavigationLayoutType.FullScreen
+        return NavigationLayoutType.FULL_SCREEN
     }
 
     return when (widthSizeClass) {
         WindowWidthSizeClass.Compact -> {
-            NavigationLayoutType.BottomNavigation
+            NavigationLayoutType.BOTTOM_NAVIGATION
         }
 
         else -> {
             // WindowWidthSizeClass.Medium, -- tablet portrait
             // WindowWidthSizeClass.Expanded, -- phone landscape mode
-            NavigationLayoutType.NavigationRail
+            NavigationLayoutType.NAVIGATION_RAIL
         }
     }
 }
@@ -77,7 +77,6 @@ fun DAZNCodeChallengeApp(
     windowSizeClass: WindowSizeClass,
     navController: NavHostController,
     snackbarHostState: SnackbarHostState,
-    onTriggerPIPMode: () -> Unit,
 ) {
     val lastDoubleTappedNavItem = remember { mutableStateOf<AppNavItem?>(null) }
     val navBackStackEntry by navController.currentBackStackEntryAsState()
@@ -89,7 +88,7 @@ fun DAZNCodeChallengeApp(
 
     Row(modifier = modifier) {
         AnimatedVisibility(
-            visible = (navigationLayoutType == NavigationLayoutType.NavigationRail),
+            visible = (navigationLayoutType == NavigationLayoutType.NAVIGATION_RAIL),
             enter = slideInHorizontally(initialOffsetX = { -it }),
             exit = shrinkHorizontally() + fadeOut(),
         ) {
@@ -116,7 +115,7 @@ fun DAZNCodeChallengeApp(
             },
             bottomBar = {
                 AnimatedVisibility(
-                    visible = (navigationLayoutType == NavigationLayoutType.BottomNavigation),
+                    visible = (navigationLayoutType == NavigationLayoutType.BOTTOM_NAVIGATION),
                     enter = slideInVertically(initialOffsetY = { it }),
                     exit = shrinkVertically() + fadeOut(),
                 ) {
@@ -153,7 +152,6 @@ fun DAZNCodeChallengeApp(
                     }
                 },
                 onScrolledToTop = { lastDoubleTappedNavItem.value = null },
-                onTriggerPIPMode = onTriggerPIPMode,
             )
         }
     }
@@ -175,7 +173,6 @@ private fun Preview() {
                 windowSizeClass = getPreviewWindowSizeClass(),
                 navController = rememberNavController(),
                 snackbarHostState = remember { SnackbarHostState() },
-                onTriggerPIPMode = {},
             )
         }
     }

app/src/main/java/com/rwmobi/dazncodechallenge/ui/components/PictureInPictureButton.kt

@@ -0,0 +1,32 @@
+/*
+ * Copyright (c) 2024. Ryan Wong
+ * https://github.com/ryanw-mobile
+ * Sponsored by RW MobiMedia UK Limited
+ *
+ */
+
+package com.rwmobi.dazncodechallenge.ui.components
+
+import androidx.compose.material3.Icon
+import androidx.compose.material3.IconButton
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.painterResource
+import androidx.compose.ui.res.stringResource
+import com.rwmobi.dazncodechallenge.R
+
+@Composable
+fun PictureInPictureButton(
+    modifier: Modifier = Modifier,
+    onClick: () -> Unit,
+) {
+    IconButton(
+        modifier = modifier,
+        onClick = onClick,
+    ) {
+        Icon(
+            painter = painterResource(id = R.drawable.rounded_picture_in_picture_24),
+            contentDescription = stringResource(R.string.content_description_play_video_in_picture_in_picture_mode),
+        )
+    }
+}

app/src/main/java/com/rwmobi/dazncodechallenge/ui/destinations/exoplayer/ControllerTransitionState.kt

@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2024. Ryan Wong
+ * https://github.com/ryanw-mobile
+ * Sponsored by RW MobiMedia UK Limited
+ *
+ */
+
+package com.rwmobi.dazncodechallenge.ui.destinations.exoplayer
+
+import android.view.View
+
+internal enum class ControllerTransitionState {
+    GONE,
+    APPEARING,
+    VISIBLE,
+    DISAPPEARING,
+    ;
+
+    fun updateState(visibility: Int, isControllerFullyVisible: Boolean): ControllerTransitionState {
+        return when {
+            visibility == View.INVISIBLE && !isControllerFullyVisible -> GONE
+            visibility == View.VISIBLE && isControllerFullyVisible -> VISIBLE
+            visibility == View.VISIBLE && !isControllerFullyVisible -> {
+                when (this) {
+                    VISIBLE -> DISAPPEARING
+                    GONE -> APPEARING
+                    else -> DISAPPEARING
+                }
+            }
+
+            else -> GONE
+        }
+    }
+}