Refactor and add tests for hub method discovery #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berdon
approved these changes
Oct 18, 2018
|
Manually merged into master since all the open PRs dependend on each other quite a bit. I'm incorporating the feedback as a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based off the other PR.
While I was looking closely at the web socket handler I noticed that there wasn't much testing around the hub method discovery so I looked at adding some.
I opted to factor out the code into a separate internal class so that it could be more readily tested independently (though it still uses the
ServicesMockerfrom the other PR for the logger factory).I did discover, through this testing, that the discovery process picked up a few methods from
objectthat I updated the code to ignore using the same method as ignoringHub<>methods.