Add feature flag for equal operator #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a feature flag to switch the equal operator from `=` to `==`. * **Feature Flag**: Add `EQUAL_OPERATOR_DOUBLE_EQUAL` to `FEATURE_FLAG` enum in `core/constant/feature-flags.ts`. * **EqualOperator Class**: Modify `EqualOperator` class in `core/node/operator.ts` to use `==` instead of `=` when `FEATURE_FLAG.EQUAL_OPERATOR_DOUBLE_EQUAL` is enabled. * **Tokenize Rules**: Add `==` to `OPERATORS` array in `core/prepare/tokenize/rules.ts`. * **Operator Precedences**: Add logic to check `FEATURE_FLAG.EQUAL_OPERATOR_DOUBLE_EQUAL` and use `==` instead of `=` in `OPERATOR_PRECEDENCES` array in `core/node/calculation.ts`. * **Tests**: Add test cases for `==` operator in `test/operand-types.test.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/rycont/dalbit-yaksok?shareId=XXXX-XXXX-XXXX-XXXX).
Deploying dalbit-yaksok with
|
| Latest commit: |
8d3b78f
|
| Status: | 🚫 Build failed. |
|
Copilot Workspace 테스트용으로 생성하였으나, 결과가 기대에 미치지 못하여 삭제 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature flag to switch the equal operator from
=to==.EQUAL_OPERATOR_DOUBLE_EQUALtoFEATURE_FLAGenum incore/constant/feature-flags.ts.EqualOperatorclass incore/node/operator.tsto use==instead of=whenFEATURE_FLAG.EQUAL_OPERATOR_DOUBLE_EQUALis enabled.==toOPERATORSarray incore/prepare/tokenize/rules.ts.FEATURE_FLAG.EQUAL_OPERATOR_DOUBLE_EQUALand use==instead of=inOPERATOR_PRECEDENCESarray incore/node/calculation.ts.==operator intest/operand-types.test.ts.For more details, open the Copilot Workspace session.