Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed else clause from restfulizer #216

Closed
wants to merge 1 commit into from

Conversation

pierlon
Copy link

@pierlon pierlon commented Nov 2, 2016

fixes issue #215

@rydurham
Copy link
Owner

rydurham commented Nov 2, 2016

Will this still work if used on a link without the "action_confirm" class?

@pierlon
Copy link
Author

pierlon commented Nov 2, 2016

Yes, the attribute onclick() is still added to the element.

@rydurham
Copy link
Owner

rydurham commented Nov 3, 2016

When I try this fix on a link that does not have the "action_confirm" class, the form does not submit.

@pierlon
Copy link
Author

pierlon commented Nov 5, 2016

I may have misunderstood you. The form submits if I confirm the action or not, so removing the else clause fixes the issue. If the link does not have the "action_confirm" class it should not have the onclick attribute.

@rydurham
Copy link
Owner

rydurham commented Nov 7, 2016

Ideally, the "action_confirm" class would be optional. If not present, the form submission would occur immediately, as intended. If present, the user would be prompted to confirm the action and the form would be submitted (or not) depending on what they choose.

@rydurham rydurham closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants