Make notification icon optional #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quexten
force-pushed
the
feature/notification-icon-optional
branch
from
087e8e9 to
2d3b2c3
Compare
quexten
force-pushed
the
feature/notification-icon-optional
branch
from
2d3b2c3 to
a21edbe
Compare
This was referenced Apr 29, 2024
|
@Jacalz The code contribution note mentions targeting the next branch, but there does not seem to be a next branch in the repo yet. Might be leftover from rymdport's code contribution note? |
Yeah, sorry. That's just a copy-paste issue. I'll get that fixed up. |
Jacalz
approved these changes
Apr 30, 2024
|
Feel free to shout if you need any more features, find more bugs etc. I'm happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Title, body, and icon should all be optional. Setting no icon currently results in broken notifications such as:
This PR fixes that by making the icon optional.
