バグのない麻雀表示機能を目指して

[index30]

目下最大のバグの5枚表示をなんとかします

[ryosan-470]

どっかのアニメのタイトルみたい

頑張って欲しい

[index30]

順子の方は判定頑張ってくれてるので刻子をなんとかしなきゃ(使命感)

[bobkuro]

ひとまず拾えた:bug:一覧

[bobkuro]

貼り忘れ

[ryosan-470]

@sga0221 の Javaコードhttps://bitbucket.org/otake_kosuke/mahjang_gochiusa/src/3f1f72bfa4681f719b679bccc2c7e38b01d56b25/Main.java?at=master
を何回かテストした結果, 2~300回に1回の割合で同じ牌が5個以上出る現象が確認されました.

個人的にコードを書き直す(関数切り分け, コード内テストの作成)をしたいのでできたらBitbucketのコード自体をGitHubに移行していただけませんか?

とりあえず再実装する場合, 基本的にはJavaで書くつもりですがもしもJavaに嫌気が差したらPythonで速さを求めるようであればC++で再実装する予定です. お願いします

[ryosan-470]

sgaのJavaコードをPythonコードに書きなおしました.

https://github.com/jtwp470/gochiusa-majong-java/blob/tango-mahjong/mahjong.py

このディレクトリ下にあるresult.txtは1.6MBありますが開くと途中以下のようなデバッグセクションがあり5個以上牌があるときの手札とランダムで選ばれた数字の組み合わせがそれぞれ残されているのでこれらとソースコードを照らしあわせてどういう条件の時にエラーとなっているか発見するのに役立ててください.(私はこれを再実装するだけで疲れました)

• 生のresult

以下はresultの上数行を取ってきたものです.

0: ['4sou', '4sou', '2man', '3man', '4man', '6man', '7man', '8man', '8man', '8man', '8man', '5man', '6man', '7man']
1: ['3sou', '3sou', '5man', '6man', '7man', '7man', '7man', '7man', '3man', '4man', '5man', '2man', '2man', '2man']
2: ['5sou', '5sou', '6man', '6man', '6man', '3man', '3man', '3man', '5man', '5man', '5man', '2man', '3man', '4man']
3: ['6sou', '6sou', '5man', '6man', '7man', '4man', '4man', '4man', '6man', '7man', '8man', '5man', '6man', '7man']
4: ['8sou', '8sou', '5man', '6man', '7man', '5man', '5man', '5man', '7man', '7man', '7man', '3man', '3man', '3man']
5: ['9sou', '9sou', '1man', '2man', '3man', '4man', '5man', '6man', '2man', '3man', '4man', '6man', '6man', '6man']
6: ['6sou', '6sou', '3man', '4man', '5man', '1man', '2man', '3man', '8man', '8man', '8man', '5man', '6man', '7man']
7: ['8sou', '8sou', '2man', '3man', '4man', '1man', '1man', '1man', '7man', '8man', '9man', '8man', '8man', '8man']
8: ['1sou', '1sou', '7man', '8man', '9man', '4man', '4man', '4man', '1man', '1man', '1man', '3man', '4man', '5man']
9: Error OCCURED
===== DEBUG =====
{'6man': 1, '9man': 3, '5man': 1, '2man': 1, '2sou': 2, '4man': 5, '3man': 1}
['2sou', '2sou', '4man', '4man', '4man', '4man', '5man', '6man', '2man', '3man', '4man', '9man', '9man', '9man']
[1, 'kotsu()', 3, 'shuntsu()', 7, 'shuntsu()', 5, 'kotsu()', 8]
===== MAKE AGAIN =====
['2sou', '2sou', '4man', '4man', '4man', '6man', '7man', '8man', '6man', '6man', '6man', '2man', '2man', '2man']
['2sou', '2sou', '4man', '4man', '4man', '6man', '7man', '8man', '6man', '6man', '6man', '2man', '2man', '2man']
10: ['6sou', '6sou', '9man', '9man', '9man', '2man', '3man', '4man', '3man', '3man', '3man', '7man', '7man', '7man']
11: ['8sou', '8sou', '6man', '6man', '6man', '4man', '4man', '4man', '2man', '2man', '2man', '3man', '3man', '3man']
12: ['3sou', '3sou', '7man', '8man', '9man', '5man', '6man', '7man', '5man', '6man', '7man', '8man', '8man', '8man']
13: ['4sou', '4sou', '2man', '2man', '2man', '6man', '6man', '6man', '7man', '8man', '9man', '4man', '5man', '6man']
14: ['4sou', '4sou', '6man', '6man', '6man', '5man', '6man', '7man', '9man', '9man', '9man', '8man', '8man', '8man']
15: ['4sou', '4sou', '7man', '7man', '7man', '7man', '8man', '9man', '2man', '2man', '2man', '4man', '5man', '6man']
16: ['5sou', '5sou', '1man', '1man', '1man', '4man', '5man', '6man', '7man', '8man', '9man', '5man', '6man', '7man']
17: ['7sou', '7sou', '9man', '9man', '9man', '5man', '6man', '7man', '1man', '1man', '1man', '5man', '6man', '7man']
18: ['8sou', '8sou', '2man', '3man', '4man', '9man', '9man', '9man', '1man', '2man', '3man', '4man', '5man', '6man']
19: ['7sou', '7sou', '6man', '7man', '8man', '6man', '7man', '8man', '6man', '7man', '8man', '1man', '1man', '1man']
20: ['1sou', '1sou', '4man', '4man', '4man', '2man', '3man', '4man', '5man', '6man', '7man', '8man', '8man', '8man']
21: ['6sou', '6sou', '7man', '8man', '9man', '2man', '3man', '4man', '2man', '3man', '4man', '7man', '7man', '7man']
22: ['7sou', '7sou', '6man', '6man', '6man', '3man', '4man', '5man', '7man', '8man', '9man', '5man', '5man', '5man']
23: ['6sou', '6sou', '3man', '4man', '5man', '2man', '2man', '2man', '7man', '8man', '9man', '2man', '3man', '4man']
24: ['3sou', '3sou', '6man', '6man', '6man', '2man', '2man', '2man', '5man', '5man', '5man', '7man', '7man', '7man']
25: ['6sou', '6sou', '9man', '9man', '9man', '2man', '2man', '2man', '7man', '7man', '7man', '2man', '3man', '4man']
26: ['1sou', '1sou', '4man', '5man', '6man', '7man', '8man', '9man', '9man', '9man', '9man', '3man', '3man', '3man']
27: ['3sou', '3sou', '6man', '6man', '6man', '1man', '2man', '3man', '1man', '1man', '1man', '7man', '7man', '7man']
28: ['3sou', '3sou', '4man', '4man', '4man', '2man', '2man', '2man', '3man', '4man', '5man', '3man', '3man', '3man']
29: ['5sou', '5sou', '3man', '4man', '5man', '6man', '7man', '8man', '4man', '5man', '6man', '7man', '7man', '7man']
30: Error OCCURED
===== DEBUG =====
{'6man': 1, '9man': 1, '2man': 1, '7man': 2, '8man': 5, '5sou': 2, '4man': 1, '3man': 1}
['5sou', '5sou', '6man', '7man', '8man', '2man', '3man', '4man', '8man', '8man', '8man', '7man', '8man', '9man']
[4, 'shuntsu()', 9, 'shuntsu()', 5, 'kotsu()', 7, 'shuntsu()', 10]
===== MAKE AGAIN =====
['7sou', '7sou', '4man', '4man', '4man', '8man', '8man', '8man', '6man', '6man', '6man', '5man', '5man', '5man']
['7sou', '7sou', '4man', '4man', '4man', '8man', '8man', '8man', '6man', '6man', '6man', '5man', '5man', '5man']
31: ['8sou', '8sou', '3man', '4man', '5man', '4man', '4man', '4man', '9man', '9man', '9man', '3man', '3man', '3man']

[ryosan-470]

個人的にはこのバグをなくすのは難しいと思うので諦めてチェック機能を入れてもし5個以上吐いている場合はやり直しという実装にしたほうが楽かなぁと思いました

[ytmt365]

5枚使いを防止する & その他少し機能を追加したものを(ほとんど一から)実装中です．できたら投げます

[ryosan-470]

🙆‍♀️

Thanks to all contributors, debuggers and consumers!