Make unit optional for @setting, fix type hint for choices (#1519)

rytilahti · Sep 6, 2022 · d544083 · d544083
1 parent 207a053
commit d544083
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/miio/devicestatus.py b/miio/devicestatus.py
@@ -2,7 +2,16 @@
 import logging
 import warnings
 from enum import Enum
-from typing import Callable, Dict, Optional, Union, get_args, get_origin, get_type_hints
+from typing import (
+    Callable,
+    Dict,
+    Optional,
+    Type,
+    Union,
+    get_args,
+    get_origin,
+    get_type_hints,
+)
 
 from .descriptors import (
     EnumSettingDescriptor,
@@ -165,11 +174,11 @@ def setting(
     *,
     setter: Optional[Callable] = None,
     setter_name: Optional[str] = None,
-    unit: str,
+    unit: Optional[str] = None,
     min_value: Optional[int] = None,
     max_value: Optional[int] = None,
     step: Optional[int] = None,
-    choices: Optional[Enum] = None,
+    choices: Optional[Type[Enum]] = None,
     choices_attribute: Optional[str] = None,
     **kwargs,
 ):