Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not get battery status for mains powered devices #1131

Merged
merged 6 commits into from
Sep 5, 2021

Conversation

starkillerOG
Copy link
Contributor

This schould fix the errors as reported here: #1121 (comment)
If the battery status is requested from a mains powered device like the lumi.plug.mmeu01 it gives an error like:
miio.exceptions.DeviceError: {'code': -4003, 'message': 'prop or action not exist'}

@starkillerOG
Copy link
Contributor Author

@rytilahti could you look at this and merge?

@starkillerOG
Copy link
Contributor Author

@syssi any more suggestions?

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

Merging #1131 (d16dd98) into master (981368c) will decrease coverage by 0.05%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   74.87%   74.81%   -0.06%     
==========================================
  Files          76       76              
  Lines        8999     9006       +7     
  Branches      767      769       +2     
==========================================
  Hits         6738     6738              
- Misses       2077     2084       +7     
  Partials      184      184              
Impacted Files Coverage Δ
miio/gateway/devices/subdevice.py 36.87% <22.22%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981368c...d16dd98. Read the comment docs.

@syssi
Copy link
Collaborator

syssi commented Sep 4, 2021

I will merge this PR later the day. I want to give @rytilahti the chance to react.

@starkillerOG
Copy link
Contributor Author

I think this can now be merged

@syssi syssi merged commit 9ad62be into rytilahti:master Sep 5, 2021
@rytilahti rytilahti added the bug label Nov 30, 2021
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants