roborock: auto empty dustbin support

[craigcabrey]

addresses #1107

This is just an initial pass at this, probably more needs to be done. Will also look at the home assistant component.

Example CLI run:

(miio-runtime) [craigcabrey@alto python-miio]$ python3 miio/cli.py vacuum --ip 192.168.10.222 --token XXXX dust_collection_mode
Running command dust_collection_mode
DustCollectionMode.Smart

[rytilahti]

Thanks for the PR @craigcabrey!

As we want to have some sort of feature flags at some point to allow downstreams to decide which features are supported, could you please add a guard if clause to check for the models supporting this feature prior to calling any of the methods? You could raise a VacuumException("Device does not support dustbin emptying") or something similar when trying to run these commands on a non-supported devices.

That would be only the s7 and s7+ for the time being, I suppose?

[craigcabrey]

As we want to have some sort of feature flags at some point to allow downstreams to decide which features are supported, could you please add a guard if clause to check for the models supporting this feature prior to calling any of the methods? You could raise a VacuumException("Device does not support dustbin emptying") or something similar when trying to run these commands on a non-supported devices.

Yea, that works. It's a little ugly but over time with a feature flag framework we could clean it up.

That would be only the s7 and s7+ for the time being, I suppose?

There is no S7+, just the S7. S7+ is a bundle of the S7 with the auto empty bin.

[rytilahti]

Yea, that works. It's a little ugly but over time with a feature flag framework we could clean it up.

Indeed, I have some code around locally, but I haven't yet figured out what's the best approach to make it generic among all supported devices. But this will do for now, it's fairly simple to replace that with something more generic when the time comes.

There is no S7+, just the S7. S7+ is a bundle of the S7 with the auto empty bin.

Ah, thanks for the clarification. This looks good to go as soon as the checks pass 👍 Please run pre-commit run -a or tox -e lint locally to fix it.

[rytilahti]

This is ready to be merged as soon as the checks pass 👍