Deprecate roborock specific miio.Vacuum #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
force-pushed
the
janitor/vacuum/deprecate_vacuum
branch
from
c098a3a
to
b7c0f9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
+ Coverage 78.39% 78.46% +0.07%
==========================================
Files 88 89 +1
Lines 9656 9669 +13
Branches 1129 1130 +1
==========================================
+ Hits 7570 7587 +17
+ Misses 1897 1893 -4
Partials 189 189
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make
Vacuumas a usable base class for all vacuum implementations in the future, let's inform potential downstream users to convert their code to use the roborockvacuum class:miio.Vacuum()instructs now to use theRoborockVacuummiio.vacuumexposes the roborockvacuum internals while giving a deprecation warningThis should not break any existing code but marking it as such anyway to give it more visibility in the changelog.