Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining callable setters for switches and settings #1504

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Aug 15, 2022

This fixes a logic flaw that made it impossible to define a setter callable for switches and settings.

Includes a couple of unrelated doc fixes to get the tests pass.

@rytilahti rytilahti changed the title Allow defining only setters for switches and settings Allow defining callable setters for switches and settings Aug 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #1504 (a582904) into master (26987b5) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
- Coverage   82.62%   82.61%   -0.02%     
==========================================
  Files         142      142              
  Lines       14078    14080       +2     
  Branches     3390     3392       +2     
==========================================
  Hits        11632    11632              
  Misses       2223     2223              
- Partials      223      225       +2     
Impacted Files Coverage Δ
.../integrations/airpurifier/dmaker/airfresh_t2017.py 96.15% <ø> (ø)
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 74.38% <ø> (ø)
miio/device.py 56.00% <14.28%> (-0.65%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti force-pushed the fix/fix_setter_setter_name branch from 3f9a492 to a582904 Compare August 15, 2022 01:29
@rytilahti rytilahti merged commit b656151 into master Aug 15, 2022
@rytilahti rytilahti deleted the fix/fix_setter_setter_name branch August 15, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants