Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test-properties to under devtools command #1505

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

rytilahti
Copy link
Owner

The test-properties should have never been a part of the main Device class, this PR rectifies this by creating a new click group devtools that can be furthermore extended with other tooling.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #1505 (ba0df30) into master (b656151) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
- Coverage   82.61%   82.52%   -0.09%     
==========================================
  Files         142      143       +1     
  Lines       14080    14091      +11     
  Branches     3392     3399       +7     
==========================================
- Hits        11632    11629       -3     
- Misses       2223     2237      +14     
  Partials      225      225              
Impacted Files Coverage Δ
miio/device.py 81.89% <ø> (+25.89%) ⬆️
miio/devtools.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti changed the title Move test-properties out from Device Move test-properties to under devtools command Aug 15, 2022
@rytilahti rytilahti merged commit c0ee8ad into master Aug 15, 2022
@rytilahti rytilahti deleted the janitor/devtools_refactor branch August 15, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants