-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix roborock timers' next_schedule on repeated requests #1520
Conversation
c9a6bbb
to
5394149
Compare
Codecov Report
@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
+ Coverage 82.15% 82.21% +0.05%
==========================================
Files 145 145
Lines 14161 14168 +7
Branches 3416 3418 +2
==========================================
+ Hits 11634 11648 +14
+ Misses 2302 2295 -7
Partials 225 225
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4505a99
to
0864650
Compare
This also fixes wrong type information in the Timer constructor
0864650
to
a85e42f
Compare
Had to add a tests to make codecov happy. While doing this I fixed a typing mistake in the init function of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the 3.11-dev is sometimes flaky so let's ignore that for now. Thanks @phil9909! 👍
Any plans to create a release soon? |
Hi @phil9909, the current master has diverged so much that it's not a simple task to create a new release from it, but I might consider creating a new point release based on the latest release and some cherry-picked fixes if there is an urgent need that cannot wait? |
Every call to
get_next
of acroniter
instance returns a different timestamp (because it's a cron iterator).Because of this
Timer.next_schedule
will return different values each time. I don't think this is intended.This PR will fix this behavior.