Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more status codes for dreamevacuum #1650

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Add more status codes for dreamevacuum #1650

merged 1 commit into from
Jan 4, 2023

Conversation

zoic21
Copy link
Contributor

@zoic21 zoic21 commented Jan 4, 2023

Complete device status, I'am just not sur for ChargingComplete = 13, on my model (L10S ultra) it's Charging Complete, I hope it's same for all model

Complete device status, I'am just not sur for `ChargingComplete = 13`, on my model (L10S ultra) it's Charging Complete, I hope it's same for all model
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #1650 (66182f7) into master (329df73) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1650   +/-   ##
=======================================
  Coverage   80.36%   80.36%           
=======================================
  Files         161      161           
  Lines       15988    15994    +6     
  Branches     3607     3607           
=======================================
+ Hits        12848    12854    +6     
  Misses       2877     2877           
  Partials      263      263           
Impacted Files Coverage Δ
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 75.07% <100.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti changed the title Update dreamevacuum_miot.py Add more status codes for dreamevacuum Jan 4, 2023
@rytilahti
Copy link
Owner

Unfortunately, the mapping is the same for all models, however, as the mc1808 does not seem to report that 13 at all (based on testing using the simulator), I think we can merge this.

Here's the output of some models I checked using the simulator (e.g., miiocli -d devtools miot-simulator --model dreame.vacuum.mc1808) on current git master:

dreame.vacuum.p2009: Status (vacuum:status): Idle (value: 2) (from: Sweeping (1), Idle (2), Paused (3), Error (4), Go Charging (5), Charging (6), Mopping (7))

dreame.vacuum.mc1808: Status (vacuum:status): Idle (value: 2) (from: Sweeping (1), Idle (2), Paused (3), Error (4), Go Charging (5), Charging (6))

dreame.vacuum.r2228o: Status (vacuum:status): Sweeping and Mopping (value: 12) (from: Sweeping (1), Idle (2), Paused (3), Error (4), Go Charging (5), Charging (6), Drying (8), Washing (9), Mopping (7), Go Washing (10), Building (11), Sweeping and Mopping
(12), Charging Completed (13), Upgrading (14))

Btw, feel free to check if the genericmiot integration works just fine miiocli genericmiot --ip 127.0.0.1 --token 00000000000000000000000000000000 status. In the future, the separate dreamevacuum integration may be obsolete (or at least use the miotspec information behind the scenes).

@rytilahti rytilahti merged commit b2e7d1b into rytilahti:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants