Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creation of miot descriptors to miot model #1672

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Jan 15, 2023

As the descriptors are just representations of the MiotProperty or MiotAction classes, their construction belongs to the respective models and not inside the genericmiot integration.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Merging #1672 (130dde4) into master (c4dabeb) will not change coverage.
The diff coverage is 26.22%.

@@           Coverage Diff           @@
##           master    #1672   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files         161      161           
  Lines       16131    16131           
  Branches     3633     3635    +2     
=======================================
  Hits        12912    12912           
  Misses       2956     2956           
  Partials      263      263           
Impacted Files Coverage Δ
miio/miot_models.py 62.99% <17.39%> (-11.73%) ⬇️
miio/integrations/genericmiot/genericmiot.py 25.72% <22.22%> (+2.43%) ⬆️
miio/descriptors.py 96.36% <100.00%> (-0.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 1462e11 into master Jan 15, 2023
@rytilahti rytilahti deleted the refactor/genericmiot_descriptors_from_model branch January 15, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants