Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove {Light,Vacuum}Interfaces #1743

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

rytilahti
Copy link
Owner

Breaking change: VacuumInterface is removed. Descriptors can now be used to access the same information through a more generic interface.

This PR removes LightInterface (which was never part of a release) and VacuumInterface (which was mostly used to enforce the method naming inside the library).

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #1743 (6ef0fbf) into master (eca56e1) will decrease coverage by 0.23%.
The diff coverage is 92.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1743      +/-   ##
==========================================
- Coverage   81.91%   81.68%   -0.23%     
==========================================
  Files         196      193       -3     
  Lines       18081    18029      -52     
  Branches     3856     3845      -11     
==========================================
- Hits        14811    14727      -84     
- Misses       2980     3014      +34     
+ Partials      290      288       -2     
Impacted Files Coverage Δ
miio/__init__.py 100.00% <ø> (ø)
miio/integrations/yeelight/light/yeelight.py 77.98% <40.00%> (-0.17%) ⬇️
miio/identifiers.py 100.00% <100.00%> (ø)
...io/integrations/dreame/vacuum/dreamevacuum_miot.py 74.39% <100.00%> (-0.68%) ⬇️
miio/integrations/ijai/vacuum/pro2vacuum.py 96.89% <100.00%> (-1.26%) ⬇️
miio/integrations/mijia/vacuum/g1vacuum.py 73.07% <100.00%> (-1.29%) ⬇️
miio/integrations/roborock/vacuum/vacuum.py 62.38% <100.00%> (-2.45%) ⬇️
...o/integrations/roborock/vacuum/vacuumcontainers.py 83.16% <100.00%> (-2.76%) ⬇️
...io/integrations/roidmi/vacuum/roidmivacuum_miot.py 89.14% <100.00%> (-0.59%) ⬇️
miio/integrations/viomi/vacuum/viomivacuum.py 58.63% <100.00%> (-0.64%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 69a5ff9 into master Feb 21, 2023
@rytilahti rytilahti deleted the janitor/remove_interfaces branch February 21, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants