Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for main module imports #1813

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

rytilahti
Copy link
Owner

This instructs users to use direct imports or to use DeviceFactory.create() instead of importing directly through the miio module.

Fixes #1696

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #1813 (84c7a10) into master (fb0a63b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1813   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         192      192           
  Lines       18513    18526   +13     
  Branches     4011     4014    +3     
=======================================
+ Hits        14969    14980   +11     
- Misses       3266     3268    +2     
  Partials      278      278           
Files Changed Coverage Δ
miio/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 6171ec5 into master Aug 27, 2023
14 of 18 checks passed
@rytilahti rytilahti deleted the janitor/add_deprecation_warnings branch August 27, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding __getattr__ to miio to inform about the breaking changes.
1 participant