Features of mixed air purifier models added #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 28, 2018
| assert self.state().sleep_mode_learn_count == self.device.start_state["sleep_data_num"] | ||
| assert self.state().extra_features == self.device.start_state["app_extra"] | ||
| assert self.state().turbo_mode_supported == (self.device.start_state["app_extra"] == 1) | ||
| assert self.state().auto_detect == (self.device.start_state["act_det"] == 'on') |
There was a problem hiding this comment.
line too long (87 > 79 characters)
| assert self.state().sleep_time == self.device.start_state["sleep_time"] | ||
| assert self.state().sleep_mode_learn_count == self.device.start_state["sleep_data_num"] | ||
| assert self.state().extra_features == self.device.start_state["app_extra"] | ||
| assert self.state().turbo_mode_supported == (self.device.start_state["app_extra"] == 1) |
There was a problem hiding this comment.
line too long (95 > 79 characters)
| assert self.state().sleep_mode == OperationMode(self.device.start_state["sleep_mode"]) | ||
| assert self.state().sleep_time == self.device.start_state["sleep_time"] | ||
| assert self.state().sleep_mode_learn_count == self.device.start_state["sleep_data_num"] | ||
| assert self.state().extra_features == self.device.start_state["app_extra"] |
There was a problem hiding this comment.
line too long (82 > 79 characters)
| assert self.state().filter_rfid_tag == self.device.start_state["rfid_tag"] | ||
| assert self.state().sleep_mode == OperationMode(self.device.start_state["sleep_mode"]) | ||
| assert self.state().sleep_time == self.device.start_state["sleep_time"] | ||
| assert self.state().sleep_mode_learn_count == self.device.start_state["sleep_data_num"] |
There was a problem hiding this comment.
line too long (95 > 79 characters)
| assert self.state().led == (self.device.start_state["led"] == 'on') | ||
| assert self.state().led_brightness == LedBrightness(self.device.start_state["led_b"]) | ||
| assert self.state().buzzer == (self.device.start_state["buzzer"] == 'on') | ||
| assert self.state().child_lock == (self.device.start_state["child_lock"] == 'on') | ||
| assert self.state().illuminance == self.device.start_state["bright"] | ||
| assert self.state().volume == self.device.start_state["volume"] | ||
| assert self.state().filter_rfid_product_id == self.device.start_state["rfid_product_id"] | ||
| assert self.state().filter_rfid_tag == self.device.start_state["rfid_tag"] | ||
| assert self.state().sleep_mode == OperationMode(self.device.start_state["sleep_mode"]) |
There was a problem hiding this comment.
line too long (94 > 79 characters)
rytilahti
approved these changes
Jan 28, 2018
miio/airpurifier.py
Outdated
|
|
||
| @property | ||
| def turbo_mode_supported(self) -> Optional[bool]: | ||
| return self.data["app_extra"] == 1 |
There was a problem hiding this comment.
This will return a bool for any value of app_extra, so no need to mark it Optional here.
miio/airpurifier.py
Outdated
| @property | ||
| def auto_detect(self) -> Optional[bool]: | ||
| """Return True if auto detect is enabled.""" | ||
| return self.data["act_det"] == "on" |
rytilahti
reviewed
Jan 28, 2018
miio/airpurifier.py
Outdated
| @property | ||
| def sleep_mode(self) -> Optional[OperationMode]: | ||
| """Operation mode of the sleep state. (Idle vs. Silent)""" | ||
| return OperationMode(self.data["sleep_mode"]) |
There was a problem hiding this comment.
Here's another optional, I'm unsure what happens if the sleep_mode is None, will it just raise an exception or will it return an OperationMode (which one?)?
There was a problem hiding this comment.
It will return "None" now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.